Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$50] We should not allow increasing Working Days more than fit Resource Booking #37

Closed
maxceem opened this issue Jun 17, 2021 · 5 comments
Labels
ACCEPTED CF Issues for Community Fixes enhancement New feature or request P4 PAID QA Pass on Prod

Comments

@maxceem
Copy link
Contributor

maxceem commented Jun 17, 2021

image

To implement this we have to create a reusable method which would return maximum allowed daysWorked for the WorkPeriod inside Resource Booking.

Tooltips:

  • we already cannot decrease the number of working days to be less than daysPaid
  • we have to explain to the user why they cannot decrease or increase the working days number by showing the reason in Tooltip
  • to do so we have to show tooltip with the reason when the user hover mouse on the - or + buttons (only when they cannot press them):
    • Cannot decrease "Working Days" to less than day already paid: ${daysPaid}
    • Cannot increase "Working Days" because the end date of the Resource Booking is ${RB.endDate}
@maxceem maxceem added the enhancement New feature or request label Jun 21, 2021
@maxceem maxceem added the CF Issues for Community Fixes label Jul 3, 2021
@maxceem maxceem changed the title We should not allow increasing Working Days more than fit Resource Booking [$50] We should not allow increasing Working Days more than fit Resource Booking Jul 3, 2021
@maxceem maxceem added the P4 label Jul 3, 2021
maxceem added a commit that referenced this issue Jul 6, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Jul 6, 2021

Additionally disabled decrease button when the current value is 0 because we cannot make it less. We don't show tooltip in such case, because the reason for disabling button is clear.

@sandhiyakavi
Copy link
Collaborator

@maxceem I am able to see some '+' and '-' are slightly bolder than others.
image

Other than above, functionality wise everything is working fine.
image
image
image

@maxceem
Copy link
Contributor Author

maxceem commented Jul 6, 2021

@sandhiyakavi I believe the issue with bolder - and + is a different existent issue and it's not connected with the functionality we implemented in this issue. Can we track it separately? Also, could you, please, mention your browser and operation system, I believe it only happens on some OS and browser, as it doesn't happen to me.

@maxceem
Copy link
Contributor Author

maxceem commented Jul 7, 2021

@sandhiyakavi
Copy link
Collaborator

Verified on Prod Env with @nkumar-topcoder

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ACCEPTED CF Issues for Community Fixes enhancement New feature or request P4 PAID QA Pass on Prod
Projects
None yet
Development

No branches or pull requests

2 participants