Green tick displayed for Working Days which is not actually changed.

[sandhiyakavi]

Description:

Refer #50 (comment):

Currently if we try to increase WorkingDays beyond its fitting to the RB dates,error message is getting displayed but if we try to again change it back to its previous number(without refreshing), the green tick mark is getting displayed which should not happen as the number is not changed in this case.

bandicam.2021-07-05.18-17-48-257.mp4

[maxceem]

I suggest the next solution:

• if error during API request happens, we have to revert to the previous value, so this case as shown in the video would work like this:
  • current value is 0
  • we increase value to 1
  • error happens during server request
  • we revert the value to the previous one 0
• the tricky moment how to handle a case, where we click increase/decrease several times and some requests failed and some of the are success, can we make a nice logic in such a case

[maxceem]

We implemented it another way via #37.
So we don't allow to increase/decrease the value if that value is not suitable and this error would never happen now.

It may still happen that some other error would happen on the server, but the chance is very small, so I suggest leave such rare edge cases as it is, because fixing this issue for such edge cases could be quite complex in comparison with issue severity. If we get feedback from admins that they come to this issue again we could consider fixing it.

What do you think @sandhiyakavi?

[sandhiyakavi]

@maxceem Yes, with #37 fix this issue won't happen

[maxceem]

@sandhiyakavi as #37 is implemented now, I guess we may consider this issue as resolved, as this would rarely happen now.

[sandhiyakavi]

Issue resolved with #37