This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Qa integration #692
Merged
Qa integration #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etCountyObjFromIP methods. Tests for getCountyObjFromIP are not working as expected so they are excluded for now.
Sup 2936 tc input tests
…ests Sup 2964 tc font stockart tests
… top are truncated. -- Reduced padding from all sides for the challenge card header to accommodate multiple lines for the challenge name -- Added tooltip for the challenge names to allow users to view full challenge name when it overflows even from the 3rd line -- Reduced font size of challenge name and line height in the header -- Cleaned up DOM structure for the header (removed .top div) -- Flex based layout for header, details and roles section in the challenge card. Right now there is min-height constraint for header and details section which prevents them to take space dynamically. If remove that restriction, there would be different challenge card headers with different headers, which is not looking that great to me.
…ices Techdebt/unittests for services
…ctives Fixed error in running badges-tooltip and toggle-password directives unit tests.
Sup 2935 tc file tests
Sup 2996 controller tests
* dev: Update specs.html Add unit tests for both submissions controllers Add tests for tc-file-input Add spec file for tc-file-input Unit tests for compileReviewItems, npad, setupLoginEventMetrics and getCountyObjFromIP methods. Tests for getCountyObjFromIP are not working as expected so they are excluded for now. Unit tests for getParameterByName, storeById, parseQuestions and parseAnswers. Unit tests for getSocialUserData and getPageTitle methods Fixed error in running badges-tooltip and toggle-password directives unit tests.
…-my-past-challenges SUP-2994, My Challenges | | Empty page when loading past challenges
* dev: SUP-2994, My Challenges | | Empty page when loading past challenges
… top are truncated. -- Implemented tech review suggestions
…title-visiblity SUP-2412, [Usersnap] For all contests, almost all of the types at the top are truncated. Merging to get changes in dev for PM to review.
…hallenges-after-unregister SUP-2961, Dashboard: Active challenges not showing on dashboard after user unregisters Merging as it seems not so complicated change.
Fix styles for login buttons in header
Show assembly instead of assembly competition
…-republic-korea SUP-2990, Usersnap - Can't change country to Republic of Korea
-- Updated the content
…15-mom SUP-3005, Update Dec '15 Members of the Month
…nt-directives-ut-fix Trying to fix the unit tests error appearing in qa-merge branch.
… top are truncated. -- More suggestions, by Victor, implemented.
…title-visiblity SUP-2412, [Usersnap] For all contests, almost all of the types at the top are truncated.
Sup 3006 upload complete
-- Fixed alignment issues with design and develop tracks, data science track is already working fine.
…ment-issue-profile-subtrack SUP-3014, [Profile] Issues with card alignment
Add develop submission pages
Add error messages for all cases
dev to QA
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.