This repository was archived by the owner on Mar 4, 2025. It is now read-only.
SUP-2412, [Usersnap] For all contests, almost all of the types at the top are truncated. #666
+96
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 18, 2016 15:40
… top are truncated. -- Reduced padding from all sides for the challenge card header to accommodate multiple lines for the challenge name -- Added tooltip for the challenge names to allow users to view full challenge name when it overflows even from the 3rd line -- Reduced font size of challenge name and line height in the header -- Cleaned up DOM structure for the header (removed .top div) -- Flex based layout for header, details and roles section in the challenge card. Right now there is min-height constraint for header and details section which prevents them to take space dynamically. If remove that restriction, there would be different challenge card headers with different headers, which is not looking that great to me.
* dev: Update specs.html Add unit tests for both submissions controllers Add tests for tc-file-input Add spec file for tc-file-input Unit tests for compileReviewItems, npad, setupLoginEventMetrics and getCountyObjFromIP methods. Tests for getCountyObjFromIP are not working as expected so they are excluded for now. Unit tests for getParameterByName, storeById, parseQuestions and parseAnswers. Unit tests for getSocialUserData and getPageTitle methods Fixed error in running badges-tooltip and toggle-password directives unit tests.
* dev: SUP-2994, My Challenges | | Empty page when loading past challenges
… top are truncated. -- Implemented tech review suggestions
vikasrohit
pushed a commit
that referenced
this pull request
Jan 19, 2016
…title-visiblity SUP-2412, [Usersnap] For all contests, almost all of the types at the top are truncated. Merging to get changes in dev for PM to review.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nlitwin @vic-appirio Please let me know if you find anything out of standards. I have tried to do minimum refactoring as we need this fix on production soon and if I do full refactoring according to BEM conventions, it would take some time to get everything in shape again. Further, even with these minimum changes, there is possibility of mis-aligned cards some where in the application, if you find any such instance please let me know.
-- Reduced padding from all sides for the challenge card header to accommodate multiple lines for the challenge name
-- Added tooltip for the challenge names to allow users to view full challenge name when it overflows even from the 3rd line
-- Reduced font size of challenge name and line height in the header
-- Cleaned up DOM structure for the header (removed .top div)
-- Flex based layout for header, details and roles section in the challenge card. Right now there is min-height constraint for header and details section which prevents them to take space dynamically. If remove that restriction, there would be different challenge card headers with different headers, which is not looking that great to me.
@vic-appirio if you find the padding around header, you can control the padding of header from header css class now. Earlier it was controlled separately by each child component of the header.