Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Feature/sup 2895 placement fix f2f challenges #628

Merged
merged 4 commits into from
Dec 29, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions app/services/challenge.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,8 @@
function processPastSRM(challenge) {
if (Array.isArray(challenge.rounds) && challenge.rounds.length
&& challenge.rounds[0].userSRMDetails) {
challenge.newRating = challenge.rounds[0].userMMDetails.newRating;
challenge.pointTotal = challenge.rounds[0].userMMDetails.pointTotal;
challenge.newRating = challenge.rounds[0].userSRMDetails.newRating;
challenge.finalPoints = challenge.rounds[0].userSRMDetails.finalPoints;
}
}

Expand All @@ -180,10 +180,6 @@
// process placement for challenges having winningPlacements array in response
if (Array.isArray(challenge.userDetails.winningPlacements)) {
challenge.highestPlacement = _.min(challenge.userDetails.winningPlacements);
challenge.wonFirst = challenge.highestPlacement == 1;
if (challenge.highestPlacement === 0) {
challenge.highestPlacement = null;
}
}
// process placement for design challenges
if (challenge.track == 'DESIGN' && challenge.userDetails.submissions && challenge.userDetails.submissions.length > 0) {
Expand All @@ -192,11 +188,17 @@
challenge.highestPlacement = _.min(challenge.userDetails.submissions.filter(function(submission) {
return submission.type === CONSTANTS.SUBMISSION_TYPE_CONTEST && submission.placement;
}), 'placement').placement;

if (challenge.highestPlacement == 1) {
challenge.wonFirst = true;
}
}
if (challenge.track === 'DEVELOP' && challenge.subTrack === 'FIRST_2_FINISH') {
challenge.highestPlacement = _.min(challenge.userDetails.submissions.filter(function(submission) {
return submission.type === CONSTANTS.SUBMISSION_TYPE_CONTEST
&& submission.status === CONSTANTS.STATUS_ACTIVE && submission.placement;
}), 'placement').placement;
}
if (challenge.highestPlacement === 0) {
challenge.highestPlacement = null;
}
challenge.wonFirst = challenge.highestPlacement == 1;

challenge.userHasSubmitterRole = false;

Expand Down
Loading