This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Feature/sup 2895 placement fix f2f challenges #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 21, 2015 12:25
-- Handled placement by looking into submission for F2F challenges.
* dev: added last icon Cleanup link updates fixed link SUP-2728, Add iOS community to Onboarding page (Skill picker) SUP-2728, Add iOS community to Onboarding page (Skill picker) added updated icons added members links Pass in userId updated link added extra link added links SUP-2773, [Usersnap] New Usersnap feedback logo of android skill is wrong SUP-2881, Show placements on challenge cards only for "Contest Submission" type submissions SUP-2883, URL should be removed after successful adding as web link. SUP-2883, URL should be removed after successful adding as web link. SUP-2728, Add iOS community to Onboarding page (Skill picker) SUP-2728, Add iOS community to Onboarding page (Skill picker)
-- Validated submission type of submission for calculating the placement of the user for a challenge. -- Added unit tests for processPastChallenges method of challenge service.
-- Write unit tests for processPastSRM and processPastMarathonMatch methods -- Fixed bug in processPastSRM method, though the method is not used anywhere as of now
|
lgtm! |
|
Thanks @nlitwin |
vikasrohit
pushed a commit
that referenced
this pull request
Dec 29, 2015
…fix-f2f-challenges Feature/sup 2895 placement fix f2f challenges
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nlitwin @parthshah @tladendo Please let me know if I can improve anything here
-- Validated submission type of submission for calculating the placement of the user for a challenge.
-- Added unit tests for processPastChallenges method of challenge service.
-- Write unit tests for processPastSRM and processPastMarathonMatch methods
-- Fixed bug in processPastSRM method, though the method is not used anywhere as of now