Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Fixed spacing on design cards #519

Merged
merged 1 commit into from
Nov 3, 2015
Merged

Fixed spacing on design cards #519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion assets/css/directives/challenge-tile.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ challenge-tile .challenge.tile-view {

// roles bar is common for both active and completed
.roles {
width: 100%;
width: 101%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think to fix this issue we should fix the container (challenge-tile .challenge.tile-view), which has a set height. The .roles p tag is overflowing past the card. The parent should have the border and p.roles should just be at the bottom of the container with no border. width: 101% is hard to understand what's going on and the ramifications I think. If we remove the set height (350px) on the parent, it should help. We can give min heights to the children if necessary.

border: 1px solid #e0e0e0;
border-top: none;
display: flex;
flex-direction: row;
justify-content: flex-start;
Expand Down