This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Fixed spacing on design cards #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tladendo
added a commit
that referenced
this pull request
Nov 3, 2015
…rflow Fixed spacing on design cards
| @@ -61,7 +61,9 @@ challenge-tile .challenge.tile-view { | |||
|
|
|||
| // roles bar is common for both active and completed | |||
| .roles { | |||
| width: 100%; | |||
| width: 101%; | |||
There was a problem hiding this comment.
I think to fix this issue we should fix the container (challenge-tile .challenge.tile-view), which has a set height. The .roles p tag is overflowing past the card. The parent should have the border and p.roles should just be at the bottom of the container with no border. width: 101% is hard to understand what's going on and the ramifications I think. If we remove the set height (350px) on the parent, it should help. We can give min heights to the children if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.