only open a few links externally when tc-site has new nav

[thabofletcher]

@parthshah This changes topcoder-app so the tc-site links no longer open in a new window. This needs to be merged before we go live, but shouldn't be released while topcoder-app is in beta as a standalone. I have tested it locally and the same functionality in the tc-site project in dev.

[parthshah]

Thanks Thabo!!
I'll mention this in tomorrow's standup as well but we are pushing out GA
by a week. We should get this merged and pushed up to QA this week along
with all the other redirects. Unless you think that might negatively impact
other projects / testing etc?

Thanks
Parth

On Wed, Oct 14, 2015 at 3:21 PM, Thabo [email protected] wrote:

@parthshah https://github.com/parthshah This changes topcoder-app so
the tc-site links no longer open in a new window. This needs to be merged
before we go live, but shouldn't be released while topcoder-app is in beta
as a standalone. I have tested it locally and the same functionality in the

tc-site project in dev.

You can view, comment on, or merge this pull request online at:

#361
Commit Summary

• only open a few links externally when td-site has new nav

File Changes

• M app/directives/header/header-menu-item.directive.jade
  https://github.com/appirio-tech/topcoder-app/pull/361/files#diff-0
  (2)
• M app/layout/header/header.controller.js
  https://github.com/appirio-tech/topcoder-app/pull/361/files#diff-1
  (6)

Patch Links:

• https://github.com/appirio-tech/topcoder-app/pull/361.patch
• https://github.com/appirio-tech/topcoder-app/pull/361.diff

—
Reply to this email directly or view it on GitHub
#361.

Thanks
Parth Shah

[prasadsadhu]

This is important let's get this done

Prasad

Sent from my iPhone

On Oct 14, 2015, at 6:12 PM, Parth Shah [email protected] wrote:

Thanks Thabo!!
I'll mention this in tomorrow's standup as well but we are pushing out GA
by a week. We should get this merged and pushed up to QA this week along
with all the other redirects. Unless you think that might negatively impact
other projects / testing etc?

Thanks
Parth

On Wed, Oct 14, 2015 at 3:21 PM, Thabo [email protected] wrote:

@parthshah https://github.com/parthshah This changes topcoder-app so
the tc-site links no longer open in a new window. This needs to be merged
before we go live, but shouldn't be released while topcoder-app is in beta
as a standalone. I have tested it locally and the same functionality in the

tc-site project in dev.

You can view, comment on, or merge this pull request online at:

#361
Commit Summary

• only open a few links externally when td-site has new nav

File Changes

• M app/directives/header/header-menu-item.directive.jade
  https://github.com/appirio-tech/topcoder-app/pull/361/files#diff-0
  (2)
• M app/layout/header/header.controller.js
  https://github.com/appirio-tech/topcoder-app/pull/361/files#diff-1
  (6)

Patch Links:

• https://github.com/appirio-tech/topcoder-app/pull/361.patch
• https://github.com/appirio-tech/topcoder-app/pull/361.diff

—
Reply to this email directly or view it on GitHub
#361.

Thanks
Parth Shah
—
Reply to this email directly or view it on GitHub.

[thabofletcher]

No impact on other releases, the faster we can get the release into dev the
better. I have the new nav on the wp site so we'll get to see the entire
experience a bit better in dev if we merge. I just wanted to be sure this
didn't get to prod until day 0.

Another week should make a lot of difference getting the last few static
pages in and minor changes done, that will help a lot, thanks.

-Thabo

On Wed, Oct 14, 2015 at 6:36 PM, prasad [email protected] wrote:

This is important let's get this done

Prasad

Sent from my iPhone

On Oct 14, 2015, at 6:12 PM, Parth Shah [email protected]
wrote:

Thanks Thabo!!
I'll mention this in tomorrow's standup as well but we are pushing out GA
by a week. We should get this merged and pushed up to QA this week along
with all the other redirects. Unless you think that might negatively
impact
other projects / testing etc?

Thanks
Parth

On Wed, Oct 14, 2015 at 3:21 PM, Thabo [email protected] wrote:

@parthshah https://github.com/parthshah This changes topcoder-app so
the tc-site links no longer open in a new window. This needs to be
merged
before we go live, but shouldn't be released while topcoder-app is in
beta
as a standalone. I have tested it locally and the same functionality
in the

tc-site project in dev.

You can view, comment on, or merge this pull request online at:

#361
Commit Summary

• only open a few links externally when td-site has new nav

File Changes

• M app/directives/header/header-menu-item.directive.jade
  https://github.com/appirio-tech/topcoder-app/pull/361/files#diff-0
  (2)
• M app/layout/header/header.controller.js
  https://github.com/appirio-tech/topcoder-app/pull/361/files#diff-1
  (6)

Patch Links:

• https://github.com/appirio-tech/topcoder-app/pull/361.patch
• https://github.com/appirio-tech/topcoder-app/pull/361.diff

—
Reply to this email directly or view it on GitHub
#361.

Thanks
Parth Shah
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#361 (comment)
.