Merge pull request #361 from appirio-tech/sup-1402-tc-site-new-nav

only open a few links externally when tc-site has new nav

Author: parthshah

app/directives/header/header-menu-item.directive.jade

@@ -6,7 +6,7 @@ li.submenu-item(ng-if="item.sref && !item.srefParams")
 
 // external links
 li.submenu-item(ng-if="item.href && !item.srefParams")
-  a.menu-link(ng-click="$event.stopPropagation();" ng-href="{{item.href}}" ng-class="{ 'active': isActive() }" target="_blank")
+  a.menu-link(ng-click="$event.stopPropagation();" ng-href="{{item.href}}" ng-class="{ 'active': isActive() }" target="{{ item.target ? item.target : '_self'}}")
     img.menu-icon(ng-src="{{item.icon}}")
     .menu-text {{item.text}}
 

app/layout/header/header.controller.js

@@ -21,7 +21,7 @@
           { 'href':  "/challenges/design/active/", 'text': 'DESIGN CHALLENGES', 'icon': '/images/nav/design.svg' },
           { 'href':  "/challenges/develop/active", 'text': 'DEVELOPMENT CHALLENGES', 'icon': '/images/nav/development.svg' },
           { 'href':  "/challenges/data/active", 'text': 'DATA SCIENCE CHALLENGES', 'icon': '/images/nav/data-science.svg' },
-          { 'href':  vm.constants.ARENA_URL, 'text': 'THE ARENA', 'icon': '/images/nav/srms.svg' },
+          { 'href':  vm.constants.ARENA_URL, 'text': 'THE ARENA', 'icon': '/images/nav/srms.svg', 'target': '_blank' },
       ],
       'learn': [
           { 'href': '/community/design/', 'text': 'DESIGN', 'icon': '/images/nav/scroll-design.svg' },
@@ -32,7 +32,7 @@
       'community': [
           { 'href': '/community/members/', 'text': 'MEMBERS', 'icon': '/images/nav/users.svg' },
           { 'href': '/community/member-programs/', 'text': 'PROGRAMS', 'icon': '/images/nav/medal.svg' },
-          { 'href': vm.constants.FORUMS_APP_URL, 'text': 'FORUMS', 'icon': '/images/nav/forum.svg' },
+          { 'href': vm.constants.FORUMS_APP_URL, 'text': 'FORUMS', 'icon': '/images/nav/forum.svg', 'target': '_blank' },
           { 'href': '/community/statistics/', 'text': 'STATISTICS', 'icon': '/images/nav/statistics.svg' },
           { 'href': '/community/events/', 'text': 'EVENTS', 'icon': '/images/nav/calendar.svg' },
           { 'href': '/blog/', 'text': 'BLOG', 'icon': '/images/nav/blog.svg' }
@@ -68,7 +68,7 @@
         vm.userMenu = [
           { 'sref': 'dashboard', 'text': 'DASHBOARD', 'icon': '/images/nav/dashboard.svg' },
           { 'sref': 'profile.about', 'srefParams': { 'userHandle': vm.userHandle }, 'text': 'MY PROFILE', 'icon': '/images/nav/badge.svg' },
-          { 'href':  vm.constants.COMMUNITY_URL + '/PactsMemberServlet?module=PaymentHistory&full_list=false', 'text': 'PAYMENTS', 'icon': '/images/nav/money-bag.svg' },
+          { 'href':  vm.constants.COMMUNITY_URL + '/PactsMemberServlet?module=PaymentHistory&full_list=false', 'text': 'PAYMENTS', 'icon': '/images/nav/money-bag.svg', 'target': '_blank' },
           { 'sref': 'settings.profile', 'text': 'SETTINGS', 'icon': '/images/nav/gear.svg' },
         ];