Move to kcd-scripts #86
Conversation
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 63 63
Branches 11 10 -1
=====================================
Hits 63 63
Continue to review full report at Codecov.
|
|
I''ll shamelessly ping @kentcdodds to see if he can provide some insights with regarding testing the Travis part (especially the 🙌 |
|
As far as testing, it's hard to test Travis. I normally just do trial and error 😅 |
| @@ -1,22 +1,28 @@ | |||
| { | |||
| "name": "@testing-library/vue", | |||
| "version": "2.0.0", | |||
| "version": "0.0.0-semantically-released", | |||
| "description": "Simple and complete Vue DOM testing utilities that encourage good testing practices.", | |||
| "main": "dist/vue-testing-library.js", | |||
There was a problem hiding this comment.
I believe this will need to be changed
There was a problem hiding this comment.
Oh, how come? I was expecting Travis + semantic release will set the version right before it releases.
Actually, I wanted to ask you something. I saw that semantic-release uses git commit messages to compute the required version bump. I've noticed, however, that you are not enforcing any commit structure in RTL, for instance (example). How does that work?
There was a problem hiding this comment.
Oh, sorry Kent, I thought you meant the version field, now I see you added your comment two lines below. I double checked, and since the file is called src/vue-testing-library.js, the generated dist/ folder keeps the same naming.
There was a problem hiding this comment.
When I merge pill requests I use the "Squash and merge" option which allows me to write my own commit message. Much less of a burden on contributors and I don't need commitizen.
So the idea is that we set VTL repo to only work with "squash and merge" strategy This way, by following This remove burden from contributors, because we don't have to set At least this is the idea, can't (obviously) test it until everything gets merged and we see the results 😇 If that sounds reasonable, I'd say we merge this as a patch version - in this case, I'd use a commit message that reads "chore: move building process to kcd-scripts" - and see how it goes. A lot of things (github/npm tokens, config, etc) could go wrong, but we have to try :) |
|
Okay I'm giving this a go. Wish me luck 😂 |
|
Okay, once I created the appropriate git tag ( [release] npm notice
[release] npm ERR! code E404
[release] npm ERR! 404 Not Found - PUT https://registry.npmjs.org/@testing-library%2fvue - Not found
[release] npm ERR! 404
[release] npm ERR! 404 '@testing-library/[email protected]' is not in the npm registry.It is weird because the URL actually exists and the library is obviously published 🤷♀
|
|
You have the GH_TOKEN and NPM_TOKEN set right? |
|
NPM_TOKEN was created/uploaded when I ran |
|
I just created and added an |
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
That was it @kentcdodds 💯💯💯💯 thank you!! |
|
Cool! Great job guys! Does anyone know if you can zennify the squash and merge commit message, though? |
|
I don't know if any way to automate it, but I don't see any reason to either 🤷♂️ |
|
I was just wondering, we are switching to Github at work and if you squash and merge allows to change the commit message. Guess it would be nice to avoid fix it messages 😀 |
|
Yep, it does allow you to change the message when you squash and merge 👍 |
By using
kcd-scriptswe stay one step closer to Testing Library sibling packages while removing the need to handle stuff manually.kcd-scriptsto manage npm scripts.src/__tests__to honor default config.npm run format(this is why there's a lot of small styling changes - mostly trailing commas and whitespaces around brackets).Is this a Breaking Change?:
I'd love to make sure that the
buildoutput is still okay. I removedbrowsersfrom.babelrcto use the default config (the same used in RTL, for instance).