Skip to content

Semantic release #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Semantic release #85

wants to merge 3 commits into from

Conversation

afontcu
Copy link
Member

@afontcu afontcu commented Aug 15, 2019

This PR closes #81.

This is just a draft PR to explore semantic-release and commitizen.

Tools:
https://github.com/semantic-release/semantic-release
https://github.com/commitizen/cz-cli

I've following semantic-release getting started guide, and also the "official" config for Travis. Also this tutorial came in handy.

I'm having a hard time getting a --dry-run execution to successfully perform all the required steps. I've used my account to provide tokens for both GitHub and npm, but got no luck when testing it out:

imatge

it might be due to running it before having everything in place on master, but I was hoping I could test it out before merging anything.

@afontcu
Copy link
Member Author

afontcu commented Aug 15, 2019

With the current implementation, git commit would trigger commitizen, so any contributor would be able to set the appropriate commit message.

@afontcu afontcu requested a review from dfcook August 15, 2019 16:18
@afontcu
Copy link
Member Author

afontcu commented Aug 15, 2019

I'm wondering if we should use kcd-scripts to avoid the hassle 🤔

@afontcu
Copy link
Member Author

afontcu commented Aug 15, 2019

Build failed due to commitizen only supporting node >= 10.

@dfcook
Copy link
Collaborator

dfcook commented Aug 16, 2019

imatge

This looks like it's using https to make the push (asking for username and password) not your token.

I'm wondering if we should use kcd-scripts to avoid the hassle 🤔

Are they easy enough to use? Anything that gives consistency with other testing libraries is a good think IMO.

@afontcu
Copy link
Member Author

afontcu commented Aug 16, 2019

This looks like it's using https to make the push (asking for username and password) not your token.

It is weird, though, because it created the appropriate GH token, and there's no cli option to push using SSH instead of https (docs).

@afontcu afontcu mentioned this pull request Aug 17, 2019
6 tasks
@afontcu
Copy link
Member Author

afontcu commented Aug 17, 2019

I'm wondering if we should use kcd-scripts to avoid the hassle 🤔

Gave it a go in #86

@afontcu
Copy link
Member Author

afontcu commented Aug 17, 2019

I like Kent's idea of avoiding commitizen and switching to a squash&merge strategy instead (we could disable all merging strategies on the repo) so that we are responsible for writing the right commit message.

@afontcu
Copy link
Member Author

afontcu commented Aug 18, 2019

Closing in favor of #86

@afontcu afontcu closed this Aug 18, 2019
@afontcu afontcu deleted the semantic-release branch August 18, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add semanting release bot
2 participants