Skip to content

Make button test use event emitters #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2019
Merged

Make button test use event emitters #25

merged 2 commits into from
May 28, 2019

Conversation

afontcu
Copy link
Member

@afontcu afontcu commented May 28, 2019

...instead of callback props, which are way more common in React world.

I also noticed a linting issue, so I ran npm run lint:fix and committed the difference.

Thanks for your work!

This closes #24

@dfcook dfcook merged commit e615376 into testing-library:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple Button isn't "idiomatic" Vue
2 participants