Skip to content

Simple Button isn't "idiomatic" Vue #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
afontcu opened this issue May 13, 2019 · 0 comments · Fixed by #25
Closed

Simple Button isn't "idiomatic" Vue #24

afontcu opened this issue May 13, 2019 · 0 comments · Fixed by #25

Comments

@afontcu
Copy link
Member

afontcu commented May 13, 2019

I just noticed that some tests, such as the Simple Button one, are using a callback prop approach, which is widely used in React.

However, since Vue suggests emitting events instead of passing callback functions, would it make sense to update the example and show how to test for an event to be emitted? I could help with that.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant