Skip to content

ecosystem page for react-hooks-testing-library #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

ecosystem page for react-hooks-testing-library #641

wants to merge 2 commits into from

Conversation

rawat07102
Copy link
Contributor

#20

@MatanBobi
Copy link
Member

MatanBobi commented Oct 11, 2020

Hi @rawat07102!
Thanks for this PR..
If you want in to automatically link the issue, you'll need to write something like: "Resolves #20", then the issue will be automatically closed once this PR will be merged..
Also, I'm second thinking whether this should be placed in eco-system or under the React section since this is related only to React..
Any thoughts?

@rawat07102
Copy link
Contributor Author

thanks for the suggestion @MatanBobi and it does make sense for it to be under React section but it does not depend on react-testing-library. So I guess it depends on if we want to separate based on dependency or use case.

@MatanBobi
Copy link
Member

thanks for the suggestion @MatanBobi and it does make sense for it to be under React section but it does not depend on react-testing-library. So I guess it depends on if we want to separate based on dependency or use case.

I agree, it's a little tricky but logically I'd go with that, I guess more opinions would be good..
Also, I saw that under ecosystem we already have rtl-simple-queries which is clearly related only to React..

@alexkrolick
Copy link
Collaborator

This page should go under the ecosystem section. It's where all of the libraries that aren't framework adapters go.

@MatanBobi
Copy link
Member

@rawat07102 can you please resolve the conflicts so we'll be able to merge this one? :)

@rawat07102 rawat07102 closed this by deleting the head repository Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants