Skip to content

Add docs for react-hooks-testing-library #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexkrolick opened this issue Jan 24, 2019 · 8 comments
Closed

Add docs for react-hooks-testing-library #20

alexkrolick opened this issue Jan 24, 2019 · 8 comments
Labels
good first issue 🏁 Good for newcomers help wanted 👋 Extra attention is needed

Comments

@alexkrolick
Copy link
Collaborator

alexkrolick commented Jan 24, 2019

testing-library/react-testing-library#274

@alexkrolick
Copy link
Collaborator Author

@donavon any interest in porting the examples over here?

@alexkrolick alexkrolick self-assigned this Feb 13, 2019
@alexkrolick alexkrolick mentioned this issue Feb 13, 2019
@alexkrolick alexkrolick added the missing 🙀 An API is not documented! label Feb 13, 2019
@alexkrolick alexkrolick changed the title Add docs for testHook Add docs for react-hooks-testing-library Feb 26, 2019
@alexkrolick
Copy link
Collaborator Author

This should be updated to use the external library now https://github.com/mpeyper/react-hooks-testing-library

@alexkrolick alexkrolick added help wanted 👋 Extra attention is needed good first issue 🏁 Good for newcomers and removed missing 🙀 An API is not documented! labels Feb 26, 2019
@bcarroll22
Copy link
Contributor

bcarroll22 commented Apr 19, 2019

Let me look at this, I'll see how much modification it would be to port the docs from native to here.

What section would you want it in? Ecosystem? I created a "Hook Examples" section in the recipes sidebar on native's docs (see here), but I added renderHook to the API section since we export it directly, so that wouldn't work.

@alexkrolick
Copy link
Collaborator Author

alexkrolick commented Apr 19, 2019

@bcarroll22 #64 I think I left feedback on this one that should be enough to get this done

I think we want an ecosystem link for the lib and then a Recipe for both a custom hook and a component implemented using hooks (to illustrate there are no differences between that and a class component in terms of tests)

@donavon may also have some feedback since he uses hooks testing library a lot

@alexkrolick
Copy link
Collaborator Author

TODO: finish this 😄

@rawat07102
Copy link
Contributor

rawat07102 commented Oct 8, 2020

Hey! I want to work on this, so I should make 2 different PR, one for ecosystem link and one for Recipe, right?

@alexkrolick
Copy link
Collaborator Author

@rawat07102 either way. Please take a look at #64 and work off that.

@MatanBobi
Copy link
Member

Since react-hooks-testing-library has been deprecated and merged to RTL, I'm closing this one.
Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue 🏁 Good for newcomers help wanted 👋 Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants