-
Notifications
You must be signed in to change notification settings - Fork 723
Updated react hooks example page to match react-hooks-testing-library's documentation #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: hooks
Are you sure you want to change the base?
Updated react hooks example page to match react-hooks-testing-library's documentation #64
Conversation
@alexkrolick, I think you can close this now. We still follow the same principals, but the say we're part of the |
I don't think not having a hard dependency on RTL is a requirement; I would say it belongs in the same "Ecosystem" category as jest-dom and native-testing-library -- libs that share the overall approach and complementary features. |
Agreed Alex. |
Ok cool. I'm happy for this to continue then :) |
I also let @mpeyper know that the change to no longer require |
Oh nice! |
I'm not sure about the current state of this library - is this PR accurate or do we need a reboot? |
The library is still active, and the examples shown here are still accurate (our API hasn't changed much), but some of the descriptions and links are not quite right anymore. We aren't using react-testing-library any more and the links point to the the old location before it was brought into the testing-library org. |
`react-testing-library` provides the | ||
[`testHook`](/docs/react-testing-library/api#testhook) utility to test custom | ||
hooks. | ||
[`react-hooks-testing-library`](https://github.com/mpeyper/react-hooks-testing-library) is built on top of [`react-testing-library`](/react) to create a simple test harness for [React hooks](https://reactjs.org/docs/hooks-intro.html) that handles running them within the body of a function component, as well as providing various useful utility functions for updating the inputs and retrieving the outputs of your [custom hook](https://reactjs.org/docs/hooks-custom.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should replace this description with react-hooks-testing-library "The solution" section with an updated link for react-hooks-testing-library.
I updated the current pull request to match react-hooks-testing-library's doc. I removed the blog page since it is not true anymore and I also removed testHook from the api since it is not a part of it anymore.