Skip to content

Netlify config fixes... fixes #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2020
Merged

Netlify config fixes... fixes #634

merged 3 commits into from
Oct 4, 2020

Conversation

nickserv
Copy link
Member

@nickserv nickserv commented Oct 4, 2020

I fixed some issues with the Netlify config in #598 and related merges.

@nickserv
Copy link
Member Author

nickserv commented Oct 4, 2020

By removing the stub file for the React Redux recipe, Docusaurus will no longer put the link in the sidebar. However, the redirect will still work from any old links, and the recipe link still exists in the Redux docs.

Are we okay with this? If we want to keep the link, I could revert the stub and force the redirect. However, I think having an extra file lying around just to get Docusaurus to show it in the sidebar is kinda messy. That may hopefully get easier with Docusaurus 2 though.

@kentcdodds
Copy link
Member

I'm fine with this personally. Thanks @nickmccurdy!

@kentcdodds kentcdodds merged commit c03c04e into master Oct 4, 2020
@kentcdodds kentcdodds deleted the netlify-config branch October 4, 2020 04:02
@MatanBobi
Copy link
Member

By removing the stub file for the React Redux recipe, Docusaurus will no longer put the link in the sidebar. However, the redirect will still work from any old links, and the recipe link still exists in the Redux docs.

Are we okay with this? If we want to keep the link, I could revert the stub and force the redirect. However, I think having an extra file lying around just to get Docusaurus to show it in the sidebar is kinda messy. That may hopefully get easier with Docusaurus 2 though.

@nickmccurdy
When you talk about Docusaurus 2 do you mean to render a simple Redirect component for that route?

@nickserv
Copy link
Member Author

nickserv commented Oct 9, 2020

I just meant in general, wasn't sure specifically how Docusaurus 2 would let us solve the problem. The redirect component could work but I'd rather have a way to redirect without the extra file (like our existing Netlify config).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants