fix(redirects): redirect error message url to correct page #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickmccurdy should we wait for you to merge #598 so I'll update this one accordingly? |
eps1lon
approved these changes
Sep 11, 2020
There was a problem hiding this comment.
Probably just forgotten when adding docs for testing-library/dom-testing-library#412
It's the first link under /s/. @kentcdodds Was /s/ intended to group permalinks?
|
I don't know what the |
|
@eps1lon so do you think we can merge this one? :) |
|
Tested in production and working. Thanks @eps1lon! |
nickserv
added a commit
that referenced
this pull request
Oct 4, 2020
nickserv
added a commit
that referenced
this pull request
Oct 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @eps1lon suggested in testing-library/dom-testing-library#764.
At the moment when there's no document defined and we're trying to use
screenthere's an error message with a broken link.This change is to add a redirect to the correct place if a user tries to enter the broken link.