-
Notifications
You must be signed in to change notification settings - Fork 727
Update Testing Libraries naming in docs #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
2b662d1
9c761ab
7ce9985
8c2f8a7
726b49d
2427800
07ce166
cd6f043
cf019ee
0e05f4b
0568f56
7f271a7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,9 +22,9 @@ Add this line to your project's `cypress/support/commands.js`: | |
import 'cypress-testing-library/add-commands'; | ||
``` | ||
|
||
You can now use all of `dom-testing-library`'s `getBy`, `getAllBy`, `queryBy` | ||
You can now use all of `DOM Testing Library`'s `getBy`, `getAllBy`, `queryBy` | ||
and `queryAllBy` commands. | ||
[See `dom-testing-library` API for reference](dom-testing-library/api-queries.md) | ||
[See `DOM Testing Library` API for reference](dom-testing-library/api-queries.md) | ||
|
||
## Examples | ||
|
||
|
@@ -45,9 +45,9 @@ cy.get('form').then(subject => { | |
``` | ||
|
||
`cypress-testing-library` supports both jQuery elements and DOM nodes. This is | ||
necessary because Cypress uses jQuery elements, while `dom-testing-library` | ||
necessary because Cypress uses jQuery elements, while `DOM Testing Library` | ||
expects DOM nodes. When you pass a jQuery element as `container`, it will get | ||
the first DOM node from the collection and use that as the `container` parameter | ||
for the `dom-testing-library` functions. | ||
for the `DOM Testing Library` functions. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's remove the backtics around these. It only sorta made sense before, but I don't think it makes any sense now. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done! 👍 Yet, backticks are used in several other places (here, for instance, or a couple of lines above your comment). Shoud we remove all backticks when talking about the library, now that it doesn't look like "code" anymore? Or there's another reason to modify this particular line I'm failing to see? |
||
|
||
[gh]: https://github.com/testing-library/cypress-testing-library |
Uh oh!
There was an error while loading. Please reload this page.