-
Notifications
You must be signed in to change notification settings - Fork 723
Update Testing Libraries naming in docs #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid except for 2 quick things.
expects DOM nodes. When you pass a jQuery element as `container`, it will get | ||
the first DOM node from the collection and use that as the `container` parameter | ||
for the `dom-testing-library` functions. | ||
for the `DOM Testing Library` functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the backtics around these. It only sorta made sense before, but I don't think it makes any sense now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! 👍
Yet, backticks are used in several other places (here, for instance, or a couple of lines above your comment).
Shoud we remove all backticks when talking about the library, now that it doesn't look like "code" anymore? Or there's another reason to modify this particular line I'm failing to see?
Thanks a ton! Maybe we could add a note to the old blogpost? |
So, I think I updated all references to ported libraries that are not being handled in other PRs! The blog post is still missing: would you like to add a footnote saying that names have changed, or update the blog post so it uses the new ones? |
I've merged this and if there are necessary changes we can make them in another PR. On the blog post, do what you think makes the most sense 👍 |
@all-contributors please add @afontcu for docs |
I've put up a pull request to add @afontcu! 🎉 |
Hi! 👋 As suggested in #124:
dom-testing-library
.vue-testing-library
.react-testing-library
.cypress-testing-library
.native-testing-library
.jest-native
.Also:
I didn't update the
2019-04-25-new-org
blog post where libraries are mentioned, because... well, it is an "old" post. I guess a newer blog post will be published after the migration to scoped packages has finished, so.. 🤷♀Feel free to suggest any modification!
Thanks!