Skip to content

Update Testing Libraries naming in docs #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 1, 2019
Merged

Update Testing Libraries naming in docs #125

merged 12 commits into from
Jun 1, 2019

Conversation

afontcu
Copy link
Member

@afontcu afontcu commented May 31, 2019

Hi! 👋 As suggested in #124:

  • Update dom-testing-library.
  • Update vue-testing-library.
  • Update react-testing-library.
  • Update cypress-testing-library.
  • Update native-testing-library.
  • Update jest-native.

Also:

I didn't update the 2019-04-25-new-org blog post where libraries are mentioned, because... well, it is an "old" post. I guess a newer blog post will be published after the migration to scoped packages has finished, so.. 🤷‍♀

Feel free to suggest any modification!

Thanks!

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid except for 2 quick things.

expects DOM nodes. When you pass a jQuery element as `container`, it will get
the first DOM node from the collection and use that as the `container` parameter
for the `dom-testing-library` functions.
for the `DOM Testing Library` functions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the backtics around these. It only sorta made sense before, but I don't think it makes any sense now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! 👍

Yet, backticks are used in several other places (here, for instance, or a couple of lines above your comment).

Shoud we remove all backticks when talking about the library, now that it doesn't look like "code" anymore? Or there's another reason to modify this particular line I'm failing to see?

@kentcdodds
Copy link
Member

Thanks a ton! Maybe we could add a note to the old blogpost?

@afontcu afontcu changed the title Update DOM Testing Library naming in docs Update Testing Libraries naming in docs Jun 1, 2019
@afontcu
Copy link
Member Author

afontcu commented Jun 1, 2019

So, I think I updated all references to ported libraries that are not being handled in other PRs!

The blog post is still missing: would you like to add a footnote saying that names have changed, or update the blog post so it uses the new ones?

@kentcdodds kentcdodds merged commit ab2cebb into testing-library:master Jun 1, 2019
@kentcdodds
Copy link
Member

I've merged this and if there are necessary changes we can make them in another PR.

On the blog post, do what you think makes the most sense 👍

@kentcdodds
Copy link
Member

@all-contributors please add @afontcu for docs

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @afontcu! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants