fix: eslint jest/no-if in rerender test #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@all-contributors please add @rvdkooy for tests |
|
I've put up a pull request to add @rvdkooy! 🎉 |
|
🎉 This PR is included in version 9.1.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR fixes issue: #464 by writing the test slightly different so no if statement is needed anymore
Why:
Validation step is currently failing because of the eslint rule: jest/no-if.
How:
Not doing a querySelector and checking if it found the initial input element anymore, but actually creating these elements so no queryselector is needed anymore
Checklist:
Documentation added to thedocs site
Typescript definitions updated