Skip to content

Running npm run setup -s fails #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ely-alamillo opened this issue Aug 24, 2019 · 2 comments
Closed

Running npm run setup -s fails #464

ely-alamillo opened this issue Aug 24, 2019 · 2 comments

Comments

@ely-alamillo
Copy link

  • react-testing-library version: 9.1.3
  • react version:
  • node version: 12.6.0
  • npm (or yarn) version: npm 6.9.0

What you did:

Tried to set up project following the CONTRIBUTING.md file.

What happened:

Setup failed with npm run setup -s fails with Tests should not contain if statements jest/no-if for the file react-testing-library/src/__tests__/rerender.js

Reproduction:

Run through setup instructions found in CONTRIBUTING.md.

Problem description:

Running npm run setup -s fails with Tests should not contain if statements jest/no-if for the file react-testing-library/src/__tests__/rerender.js

Suggested solution:

  1. Fix the test so it doesn't use if statements.
  2. Suppress the rule for this test case.
@afontcu
Copy link
Member

afontcu commented Aug 24, 2019

Hi @ely-alamillo, nice catch! Would you like to submit a PR to fix it? 🙌

@ely-alamillo
Copy link
Author

Issue now fixed thanks to @rvdkooy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants