-
Notifications
You must be signed in to change notification settings - Fork 1.1k
(docs) Add faq entry about dealing with multiple data-testids #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(docs) Add faq entry about dealing with multiple data-testids #4
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 5 5
=====================================
Hits 5 5 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super duper! Thanks!
@@ -1,6 +1,7 @@ | |||
{ | |||
"projectName": "react-testing-library", | |||
"projectOwner": "kentcdodds", | |||
"repoType": "github", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, I ran npm run add-contributor
, it put this in the wrong spot I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries. there was an update to all-contributors
and I haven't updated my template yet :)
) (testing-library#4) * Add toHaveClass custom matcher * Add documentation in the README * Handle the case where an element has no class
ci: 🎡 report test coverage to codeclimate
What: docs faq addition
Why: I read the faq, and even though the previous question addresses it I thought
queryByTestId
would handle this case, it doesn't so this faq addition clarifies the issue along with suggested ways to address it.How: N/A
Checklist: