Skip to content

(docs) Add faq entry about dealing with multiple data-testids #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 19, 2018

Conversation

audiolion
Copy link
Contributor

@audiolion audiolion commented Mar 19, 2018

What: docs faq addition

Why: I read the faq, and even though the previous question addresses it I thought queryByTestId would handle this case, it doesn't so this faq addition clarifies the issue along with suggested ways to address it.

How: N/A

Checklist:

  • Documentation
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table

@codecov
Copy link

codecov bot commented Mar 19, 2018

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #4   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           5      5           
=====================================
  Hits            5      5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df3df4a...20e4cbc. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super duper! Thanks!

@kentcdodds kentcdodds merged commit d79fc56 into testing-library:master Mar 19, 2018
@audiolion audiolion deleted the docs/faq-addition branch March 19, 2018 20:05
@@ -1,6 +1,7 @@
{
"projectName": "react-testing-library",
"projectOwner": "kentcdodds",
"repoType": "github",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, I ran npm run add-contributor, it put this in the wrong spot I guess?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. there was an update to all-contributors and I haven't updated my template yet :)

julienw pushed a commit to julienw/react-testing-library that referenced this pull request Dec 20, 2018
) (testing-library#4)

* Add toHaveClass custom matcher

* Add documentation in the README

* Handle the case where an element has no class
lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
ci: 🎡 report test coverage to codeclimate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants