Skip to content

POST under _mocks_ #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alejandronanez opened this issue Mar 19, 2018 · 4 comments
Closed

POST under _mocks_ #2

alejandronanez opened this issue Mar 19, 2018 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alejandronanez
Copy link
Contributor

Problem description:
Hey Kent,
I see the lib only has a get method under _mocks_, I guess it will be nice to have a POST method too. If that sounds good to you I can take a look at it.

Thanks!
@kentcdodds
Copy link
Member

Thanks @alejandronanez! We could definitely make the mock more fully-featured, but I think we should leave it for now because we don't need any other functionality.

That said, if you'd like to add a comment to that file explaining this fact so nobody else has the same concern that would be helpful! Thanks!

@kentcdodds kentcdodds added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 19, 2018
@alejandronanez
Copy link
Contributor Author

Sure! I’ll do it!

Thanks!!!!

@alejandronanez alejandronanez mentioned this issue Mar 20, 2018
Merged
4 tasks
kentcdodds pushed a commit that referenced this issue Mar 20, 2018
docs: adding docs about the other HTTP methods. (#6)
cf83b27 
* Update axios.js

Adding docs about the other HTTP methods.

* adding myself to the contributors list

Closes #2
@kentcdodds
Copy link
Member

Thanks for your help!

@alejandronanez
Copy link
Contributor Author

My pleassure!

julienw pushed a commit to julienw/react-testing-library that referenced this issue Dec 20, 2018
@gnapse
feat(matchers): add toHaveClass custom matcher (closes testing-library#2
75d12c4 
) (testing-library#4)

* Add toHaveClass custom matcher

* Add documentation in the README

* Handle the case where an element has no class
@alexkrolick alexkrolick mentioned this issue Feb 6, 2019
Closed
@alexkrolick alexkrolick mentioned this issue Jun 25, 2019
Closed
@laurage laurage mentioned this issue Apr 15, 2020
Closed
lucbpz pushed a commit to lucbpz/react-testing-library that referenced this issue Jul 26, 2020
@Gpx
Merge pull request testing-library#2 from Gpx/labels
5a4ae78 
Labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alejandronanez @kentcdodds