Skip to content

feat(no-unnecessary-act): add to Angular, Dom & Vue configs by default #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Sep 23, 2021

Part of #478

BREAKING CHANGE: no-unnecessary-act is now enabled by default in the Angular, Dom & Vue configs

@MichaelDeBoey MichaelDeBoey added enhancement New feature or request BREAKING CHANGE This change will require a major version bump labels Sep 23, 2021
@MichaelDeBoey MichaelDeBoey added this to the 5.0.0 milestone Sep 23, 2021
@MichaelDeBoey MichaelDeBoey self-assigned this Sep 23, 2021
@MichaelDeBoey MichaelDeBoey mentioned this pull request Sep 23, 2021
11 tasks
@MichaelDeBoey MichaelDeBoey changed the title feat(no-unnecessary-act): add to Angular & Vue config by default feat(no-unnecessary-act): add to Angular & Vue configs by default Sep 23, 2021
@MichaelDeBoey MichaelDeBoey force-pushed the add-no-unnecessary-act-to-angular-and-vue-config branch from 655cf54 to 2e2fd18 Compare September 23, 2021 12:10
@MichaelDeBoey MichaelDeBoey changed the title feat(no-unnecessary-act): add to Angular & Vue configs by default feat(no-unnecessary-act): add to Angular, Dom & Vue configs by default Sep 23, 2021
BREAKING CHANGE: `no-unnecessary-act` is now enabled by default in the Angular & Vue configs
@MichaelDeBoey MichaelDeBoey force-pushed the add-no-unnecessary-act-to-angular-and-vue-config branch from 305faeb to 72d6d96 Compare September 23, 2021 14:46
@Belco90
Copy link
Member

Belco90 commented Sep 23, 2021

act util is from React, so it doesn't exist in Angular, Vue or "vanilla" DOM.

@Belco90 Belco90 closed this Sep 23, 2021
@MichaelDeBoey MichaelDeBoey deleted the add-no-unnecessary-act-to-angular-and-vue-config branch September 23, 2021 15:31
@MichaelDeBoey MichaelDeBoey removed this from the 5.0.0 milestone Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants