Skip to content

Commit 72d6d96

Browse files
committed
feat(no-unnecessary-act): add to Angular & Vue configs by default
BREAKING CHANGE: `no-unnecessary-act` is now enabled by default in the Angular & Vue configs
1 parent e976dd7 commit 72d6d96

File tree

6 files changed

+10
-4
lines changed

6 files changed

+10
-4
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ To enable this configuration use the `extends` property in your
199199
| [`testing-library/no-node-access`](./docs/rules/no-node-access.md) | Disallow direct Node access | | ![angular-badge][] ![react-badge][] ![vue-badge][] |
200200
| [`testing-library/no-promise-in-fire-event`](./docs/rules/no-promise-in-fire-event.md) | Disallow the use of promises passed to a `fireEvent` method | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
201201
| [`testing-library/no-render-in-setup`](./docs/rules/no-render-in-setup.md) | Disallow the use of `render` in testing frameworks setup functions | | |
202-
| [`testing-library/no-unnecessary-act`](./docs/rules/no-unnecessary-act.md) | Disallow wrapping Testing Library utils or empty callbacks in `act` | | ![react-badge][] |
202+
| [`testing-library/no-unnecessary-act`](./docs/rules/no-unnecessary-act.md) | Disallow wrapping Testing Library utils or empty callbacks in `act` | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
203203
| [`testing-library/no-wait-for-empty-callback`](./docs/rules/no-wait-for-empty-callback.md) | Disallow empty callbacks for `waitFor` and `waitForElementToBeRemoved` | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
204204
| [`testing-library/no-wait-for-multiple-assertions`](./docs/rules/no-wait-for-multiple-assertions.md) | Disallow the use of multiple `expect` calls inside `waitFor` | | |
205205
| [`testing-library/no-wait-for-side-effects`](./docs/rules/no-wait-for-side-effects.md) | Disallow the use of side effects in `waitFor` | | |

lib/configs/angular.ts

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export = {
1313
'testing-library/no-dom-import': ['error', 'angular'],
1414
'testing-library/no-node-access': 'error',
1515
'testing-library/no-promise-in-fire-event': 'error',
16+
'testing-library/no-unnecessary-act': 'error',
1617
'testing-library/no-wait-for-empty-callback': 'error',
1718
'testing-library/prefer-find-by': 'error',
1819
'testing-library/prefer-screen-queries': 'error',

lib/configs/dom.ts

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ export = {
99
'testing-library/await-async-utils': 'error',
1010
'testing-library/no-await-sync-query': 'error',
1111
'testing-library/no-promise-in-fire-event': 'error',
12+
'testing-library/no-unnecessary-act': 'error',
1213
'testing-library/no-wait-for-empty-callback': 'error',
1314
'testing-library/prefer-find-by': 'error',
1415
'testing-library/prefer-screen-queries': 'error',

lib/configs/vue.ts

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export = {
1414
'testing-library/no-dom-import': ['error', 'vue'],
1515
'testing-library/no-node-access': 'error',
1616
'testing-library/no-promise-in-fire-event': 'error',
17+
'testing-library/no-unnecessary-act': 'error',
1718
'testing-library/no-wait-for-empty-callback': 'error',
1819
'testing-library/prefer-find-by': 'error',
1920
'testing-library/prefer-screen-queries': 'error',

lib/rules/no-unnecessary-act.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ export default createTestingLibraryRule<Options, MessageIds>({
2525
'Disallow wrapping Testing Library utils or empty callbacks in `act`',
2626
category: 'Possible Errors',
2727
recommendedConfig: {
28-
dom: false,
29-
angular: false,
28+
dom: 'error',
29+
angular: 'error',
3030
react: 'error',
31-
vue: false,
31+
vue: 'error',
3232
},
3333
},
3434
messages: {

tests/__snapshots__/index.test.ts.snap

+3
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ Object {
1818
],
1919
"testing-library/no-node-access": "error",
2020
"testing-library/no-promise-in-fire-event": "error",
21+
"testing-library/no-unnecessary-act": "error",
2122
"testing-library/no-wait-for-empty-callback": "error",
2223
"testing-library/prefer-find-by": "error",
2324
"testing-library/prefer-screen-queries": "error",
@@ -33,6 +34,7 @@ Object {
3334
"testing-library/await-async-utils": "error",
3435
"testing-library/no-await-sync-query": "error",
3536
"testing-library/no-promise-in-fire-event": "error",
37+
"testing-library/no-unnecessary-act": "error",
3638
"testing-library/no-wait-for-empty-callback": "error",
3739
"testing-library/prefer-find-by": "error",
3840
"testing-library/prefer-screen-queries": "error",
@@ -78,6 +80,7 @@ Object {
7880
],
7981
"testing-library/no-node-access": "error",
8082
"testing-library/no-promise-in-fire-event": "error",
83+
"testing-library/no-unnecessary-act": "error",
8184
"testing-library/no-wait-for-empty-callback": "error",
8285
"testing-library/prefer-find-by": "error",
8386
"testing-library/prefer-screen-queries": "error",

0 commit comments

Comments
 (0)