Skip to content

chore: create propose new rule form #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 23, 2021
Merged

chore: create propose new rule form #433

merged 8 commits into from
Jul 23, 2021

Conversation

HonkingGoose
Copy link
Contributor

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list.
  • If some rule meta info is changed, I've regenerated the plugin shared configs.

Changes

  • Create the form that contributors can use to propose a new rule

Context

Go to https://github.com/HonkingGoose/eslint-plugin-testing-library/blob/chore/430-propose-new-rule-form/.github/ISSUE_TEMPLATE/propose_new_rule.yml to see a preview of the template.

You can click one of the checkboxes in issue #430 after you've merged this.

HonkingGoose
HonkingGoose commented Jul 22, 2021
View reviewed changes
Copy link
Contributor Author

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for first round of review.

I need some help with the placeholder text.

Feel free to suggest changes to the text of any field. 😉

Belco90
Belco90 requested changes Jul 23, 2021
View reviewed changes
@HonkingGoose HonkingGoose mentioned this pull request Jul 23, 2021
Merged
3 tasks
HonkingGoose and others added 6 commits July 23, 2021 11:34
@HonkingGoose
Add link to rule naming conventions
e003f49
@HonkingGoose @Belco90
Update placeholder
cc1cd45 
Co-authored-by: Mario Beltrán Alarcón <[email protected]>
@HonkingGoose @Belco90
Capitalize Library
5f31b2e 
Co-authored-by: Mario Beltrán Alarcón <[email protected]>
@HonkingGoose @Belco90
Put existing rule description into placeholder
0d49d2b 
Co-authored-by: Mario Beltrán Alarcón <[email protected]>
@HonkingGoose @Belco90
Capitalize Library
9f9e0b5 
Co-authored-by: Mario Beltrán Alarcón <[email protected]>
@HonkingGoose @Belco90
Add placeholder for library frameworks
88402ce 
Co-authored-by: Mario Beltrán Alarcón <[email protected]>
@HonkingGoose HonkingGoose marked this pull request as ready for review July 23, 2021 09:54
@Belco90
Copy link
Member

Belco90 commented Jul 23, 2021

Let's merge the forms then!

@Belco90 Belco90 merged commit 36a7f97 into testing-library:main Jul 23, 2021
@HonkingGoose HonkingGoose deleted the chore/430-propose-new-rule-form branch July 23, 2021 10:09
@Belco90 Belco90 linked an issue Jul 23, 2021 that may be closed by this pull request
Add remaining issue forms #430
Closed
3 tasks
@MichaelDeBoey MichaelDeBoey mentioned this pull request Jul 23, 2021
Closed
3 tasks
@github-actions
Copy link

🎉 This PR is included in version 4.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add remaining issue forms
2 participants
@HonkingGoose @Belco90