Skip to content

Add remaining issue forms #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
Belco90 opened this issue Jul 22, 2021 · 9 comments · Fixed by #433, #434 or #435
Closed
3 tasks done

Add remaining issue forms #430

Belco90 opened this issue Jul 22, 2021 · 9 comments · Fixed by #433, #434 or #435
Assignees
Labels
chore Changes that affect the build system, CI config or other changes that don't modify src/test files

Comments

@Belco90
Copy link
Member

Belco90 commented Jul 22, 2021

Moving remaining issue forms from #400 (comment) to this issue.

We still want issue forms for:

Here are the details I think we need from each (heavily inspired from ESLint ones):

Propose a new rule

Labels: new rule
Fields:

  • What is the name suggested for this new rule? (required)
  • Please describe what the rule should do (required)
  • What Testing Library feature does this rule relate to? (required)
  • What Testing Library frameworks does this rule relate to? (required)
  • What category of the rule is this? (required) Select with the following options
    • Warns about a potential error
    • Suggests an alternate way of doing something
    • Other (please specify in the optional textbox at the end)
  • Provide 2-3 code examples that this rule will warn about (required)
  • Anything else? (optional)
  • Are you willing to submit a pull request to implement this rule? (required) Select with the same options as "Do you want to submit a pull request to fix this bug?" from bug template

Request a rule change

Labels: enhancement
Fields:

  • What rule do you want to change? (required)
  • Does this change cause the rule to produce more or fewer warnings? (required) Select with "more" and "fewer" options
  • How will the change be implemented? (New option, new default behavior, etc.)? (required) Free text input rather than select
  • Please provide some example code that this change will affect (required)
  • What does the rule currently do for this code? (required)
  • What will the rule do after it's changed? (required)
  • Anything else? (optional)
  • Are you willing to submit a pull request to implement this change? (required) Select with the same options as "Do you want to submit a pull request to fix this bug?" from bug template

Request a general change

Labels: enhancement
Fields:

  • What version of eslint-plugin-testing-library are you using? (required)
  • What problem do you want to solve? (required)
  • Your take on the correct solution to the problem? (required)
  • Anything else? (optional)
  • Are you willing to submit a pull request to implement this change? (required) Select with the same options as "Do you want to submit a pull request to fix this bug?" from bug template
@Belco90 Belco90 added the chore Changes that affect the build system, CI config or other changes that don't modify src/test files label Jul 22, 2021
@HonkingGoose
Copy link
Contributor

@Belco90 Is this ready for me to start work on, or do you want to discuss this with your team first?

@Belco90
Copy link
Member Author

Belco90 commented Jul 22, 2021

@Belco90 Is this ready for me to start work on, or do you want to discuss this with your team first?

Let's see what @MichaelDeBoey and @gndelia think about it!

@MichaelDeBoey
Copy link
Member

Looks good to me! 👍

@Belco90
Copy link
Member Author

Belco90 commented Jul 22, 2021

I think we are good to go, and we can update the forms later if @gndelia has some feedback.

@HonkingGoose
Copy link
Contributor

We now have PRs for all 3 forms. 😉

@Belco90
Copy link
Member Author

Belco90 commented Jul 23, 2021

All sorted now, thank you very much for your contribution @HonkingGoose!

@Belco90
Copy link
Member Author

Belco90 commented Jul 23, 2021

@all-contributors please add @HonkingGoose for maintenance

@allcontributors
Copy link
Contributor

@Belco90

I've put up a pull request to add @HonkingGoose! 🎉

@Belco90 Belco90 closed this as completed Jul 23, 2021
@HonkingGoose
Copy link
Contributor

All sorted now, thank you very much for your contribution @HonkingGoose!

You're welcome! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that affect the build system, CI config or other changes that don't modify src/test files
Projects
None yet
3 participants