Skip to content

Update await-async-utils with changes from dom-testing-library v7 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Belco90 opened this issue Mar 13, 2020 · 2 comments · Fixed by #89
Closed

Update await-async-utils with changes from dom-testing-library v7 #85

Belco90 opened this issue Mar 13, 2020 · 2 comments · Fixed by #89
Labels
enhancement New feature or request released

Comments

@Belco90
Copy link
Member

Belco90 commented Mar 13, 2020 •
edited
Loading

After release of dom-testing-library v7 there are couple of things to be updated for await-async-utils rule:

  • include waitFor as valid async util
  • update the doc to mention wait, waitForElement and waitForDomChange are now deprecated
  • make sure when waitForElementToBeRemoved receives an element rather than callback doesn't cause false positives
@Belco90 Belco90 added the enhancement New feature or request label Mar 13, 2020
This was referenced Mar 15, 2020
Merged
Merged
@Belco90
Copy link
Member Author

Belco90 commented Mar 22, 2020

This will be released on v3

@Belco90 Belco90 closed this as completed Mar 22, 2020
Belco90 added a commit that referenced this issue Mar 29, 2020
@Belco90 @timdeschryver
feat: plugin v3 (#97)
8c2dc0c 
feat(await-async-utils): reflect waitFor changes (#89)
feat: new rule no-wait-for-empty-callback (#94)
feat: new rule prefer-wait-for (#88)
feat: new rule prefer-screen-queries (#99)
BREAKING CHANGE: drop support for node v8. Min version allowed is node v10.12 (#96)
BREAKING CHANGE: rule `no-get-by-for-checking-element-not-present` removed in favor of new rule `prefer-presence-queries` (#98)

Closes #85
Closes #86
Closes #90
Closes #92
Closes #95

Co-authored-by: timdeschryver <[email protected]>
@Belco90
Copy link
Member Author

Belco90 commented Mar 29, 2020

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(await-async-utils): reflect waitFor changes testing-library/eslint-plugin-testing-library
1 participant
@Belco90