-
Notifications
You must be signed in to change notification settings - Fork 150
RFC: new rule to prefer the usage of screen #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I guess we can skip that last case for now. What about?
I think this one should be included too, which would be queries without a calle? |
Imho these would also be a warning. |
Cool, so we can create a new rule called |
👍 I'll try to implement this rule later this week |
That would be awesome :) |
* feat: add prefer-screen-queries Closes #95 * docs: review changes
Closed by #99 |
feat(await-async-utils): reflect waitFor changes (#89) feat: new rule no-wait-for-empty-callback (#94) feat: new rule prefer-wait-for (#88) feat: new rule prefer-screen-queries (#99) BREAKING CHANGE: drop support for node v8. Min version allowed is node v10.12 (#96) BREAKING CHANGE: rule `no-get-by-for-checking-element-not-present` removed in favor of new rule `prefer-presence-queries` (#98) Closes #85 Closes #86 Closes #90 Closes #92 Closes #95 Co-authored-by: timdeschryver <[email protected]>
🎉 This issue has been resolved in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
It's preferred to use
screen
when using the query functions.For a first implementation we can verify that the queries used have
screen
as callee.This doesn't take the following into account, but it makes the rule simpler.
The text was updated successfully, but these errors were encountered: