This repository was archived by the owner on Dec 12, 2022. It is now read-only.
feat: get minimum supported versions of preview app based on data passed to preview-sdk #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
force-pushed
the
fatme/preview-app-versions
branch
from
ff60fa4 to
24a78bc
Compare
5 tasks
Fatme
force-pushed
the
fatme/preview-app-versions
branch
from
24a78bc to
6553498
Compare
DimitarTachev
approved these changes
Sep 25, 2018
| @@ -0,0 +1,43 @@ | |||
| import * as axios from "axios"; | |||
| import { data } from "../preview-app-versions"; | |||
There was a problem hiding this comment.
data -> sthg like fallbackPreviewVersions
| return null; | ||
| } | ||
|
|
||
| private parseResponseCore(response: any): string { |
There was a problem hiding this comment.
parseResponseCore -> parseResponse
parseResponse -> parseResponseSafe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel to: NativeScript/nativescript-cli#3813
Remove hardcoded msvVersions and add ability to get min supported versions based on key and env. Stores msvVersionsData on github and try to make a request to get them. In case request fails, fallbacks to default data.