Skip to content

feat: pass msvKey and msvEnv to preview-sdk in order to respect different min supported versions of preview app #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2018
Merged

feat: pass msvKey and msvEnv to preview-sdk in order to respect different min supported versions of preview app #3916

merged 2 commits into from
Sep 26, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Sep 20, 2018

PR Checklist

Should be merged after this PR: telerik/nativescript-preview-sdk#6

@KristianDD
Copy link
Contributor

run ci

DimitarTachev
DimitarTachev approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@DimitarTachev DimitarTachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Don't forget to update the Preview SDK version.

@Fatme Fatme force-pushed the fatme/msv-preview-app branch from 938b08e to 2238bb1 Compare September 25, 2018 12:32
@Fatme Fatme force-pushed the fatme/msv-preview-app branch from 2238bb1 to 8d41215 Compare September 26, 2018 05:36
@Fatme Fatme merged commit c376458 into master Sep 26, 2018
@Fatme Fatme deleted the fatme/msv-preview-app branch September 26, 2018 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitarTachev DimitarTachev DimitarTachev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fatme @KristianDD @DimitarTachev