Skip to content

Improve awaiting Tarantool start/stop processes #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2019

Conversation

nicktorwald
Copy link

Add await-versions of start/stop commands for TarantoolControl class.
Improve the waiting process with an extra monitoring PID of a running
Tarantool-instance using terminal ps-command.

Fixes: #164

@nicktorwald nicktorwald requested a review from Totktonada April 17, 2019 18:31
@nicktorwald nicktorwald added the bug Something isn't working label Apr 17, 2019
@coveralls
Copy link

coveralls commented Apr 17, 2019

Coverage Status

Coverage decreased (-0.08%) to 69.754% when pulling 8121bfb on nicktorwald/gh-163-start-stop-stuck into aaa404a on master.

@nicktorwald nicktorwald force-pushed the nicktorwald/gh-163-start-stop-stuck branch 3 times, most recently from d647bed to c82d407 Compare April 19, 2019 18:06
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-163-start-stop-stuck branch from c82d407 to 13be131 Compare April 20, 2019 17:42
Add await-versions of start/stop commands for TarantoolControl class.
Improve the waiting process with an extra monitoring PID of a running
Tarantool-instance using terminal kill -0 command

Fixes: #164
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-163-start-stop-stuck branch from 13be131 to 8121bfb Compare April 20, 2019 17:47
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Totktonada Totktonada merged commit 3420575 into master Apr 20, 2019
@Totktonada Totktonada deleted the nicktorwald/gh-163-start-stop-stuck branch April 20, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable tests behaviour when starting/stopping Tarantool instances
3 participants