Improve awaiting Tarantool start/stop processes

Add await-versions of start/stop commands for TarantoolControl class.
Improve the waiting process with an extra monitoring PID of a running
Tarantool-instance using terminal kill -0 command

Fixes: #164

Author: nicktorwald

src/test/java/org/tarantool/AbstractTarantoolConnectorIT.java

@@ -235,12 +235,10 @@ protected List<?> consoleDelete(String spaceName, Object key) {
 
     protected static void stopTarantool(String instance) {
         control.stop(instance);
-        control.waitStopped("jdk-testing");
     }
 
     protected static void startTarantool(String instance) {
         control.start(instance);
-        control.waitStarted("jdk-testing");
     }
 
     /**

src/test/java/org/tarantool/AbstractTarantoolSQLConnectorIT.java

@@ -131,12 +131,10 @@ protected static TarantoolConsole openConsole(String instance) {
 
     protected static void stopTarantool(String instance) {
         control.stop(instance);
-        control.waitStopped("jdk-testing");
     }
 
     protected static void startTarantool(String instance) {
         control.start(instance);
-        control.waitStarted("jdk-testing");
     }
 
 }

src/test/java/org/tarantool/ClientReconnectClusterIT.java

@@ -36,8 +36,8 @@ public class ClientReconnectClusterIT {
     private static final String SRV1 = "replica1";
     private static final String SRV2 = "replica2";
     private static final String SRV3 = "replica3";
-    private static final int[] PORTS = { 3302, 3303, 3304 };
-    private static final int[] CONSOLE_PORTS = { 3312, 3313, 3314 };
+    private static final int[] PORTS = { 3401, 3402, 3403 };
+    private static final int[] CONSOLE_PORTS = { 3501, 3502, 3503 };
     private static TarantoolControl control;
 
     private static String REPLICATION_CONFIG = TestUtils.makeReplicationString(
@@ -410,7 +410,7 @@ private void tryAwait(CyclicBarrier barrier) {
 
     private void startInstancesAndAwait(String... instances) {
         for (String instance : instances) {
-            control.start(instance);
+            control.start(instance, false);
         }
         for (String instance : instances) {
             control.waitStarted(instance);
@@ -421,9 +421,6 @@ private void stopInstancesAndAwait(String... instances) {
         for (String instance : instances) {
             control.stop(instance);
         }
-        for (String instance : instances) {
-            control.waitStopped(instance);
-        }
     }
 
     private void expectConnected(TarantoolClientImpl client, int spaceId, int pkId) {

src/test/java/org/tarantool/ClientReconnectIT.java

@@ -26,6 +26,7 @@
 import java.util.concurrent.locks.LockSupport;
 
 public class ClientReconnectIT extends AbstractTarantoolConnectorIT {
+
     private static final String INSTANCE_NAME = "jdk-testing";
     private TarantoolClient client;
 
@@ -99,7 +100,7 @@ public SocketChannel get(int retryNumber, Throwable lastError) {
         client.syncOps().ping();
 
         // The park() will return inside connector thread.
-        LockSupport.unpark(((TarantoolClientImpl)client).connector);
+        LockSupport.unpark(((TarantoolClientImpl) client).connector);
 
         // Wait on latch as a proof that reconnect did not happen.
         // In case of a failure, latch will reach 0 before timeout occurs.
@@ -213,11 +214,54 @@ public void run() {
         });
     }
 
+    // DO NOT REMOVE THIS TEST
+    // Motivation: this test checks start/stop correctness
+    // of TarantoolControl class which is used by other tests.
+    // This test is commented out because the class is used
+    // for internal purposes only and isn't related to
+    // the connector testing.
+    //    @Test
+    //    @DisplayName("follow up the issue #164")
+    //    void testStartStopTarantoolInstance() throws InterruptedException {
+    //        int numberOfParallelInstances = 4;
+    //        CountDownLatch finished = new CountDownLatch(numberOfParallelInstances);
+    //        List<String> instancesNames = new ArrayList<>(numberOfParallelInstances);
+    //
+    //        for (int i = 0; i < numberOfParallelInstances; i++) {
+    //            String instance = "startStop" + (i + 1);
+    //            instancesNames.add(instance);
+    //            control.createInstance(
+    //                instancesNames.get(i),
+    //                LUA_FILE,
+    //                makeInstanceEnv(3401 + i + 1, 3501 + i + 1)
+    //            );
+    //            startTarantool(instancesNames.get(i));
+    //            new Thread(() -> {
+    //                for (int j = 0; j < 100; j++) {
+    //                    stopTarantool(instance);
+    //                    startTarantool(instance);
+    //                    if (j % 10 == 0) {
+    //                        System.out.println(
+    //                            Thread.currentThread().getName() + ": " + j + "% completed"
+    //                        );
+    //                    }
+    //                }
+    //                finished.countDown();
+    //            }, "Thread" + (i + 1)).start();
+    //        }
+    //
+    //        assertTrue(finished.await(2, TimeUnit.MINUTES));
+    //
+    //        for (int i = 0; i < numberOfParallelInstances; i++) {
+    //            stopTarantool(instancesNames.get(i));
+    //        }
+    //    }
+
     /**
      * Test concurrent operations, reconnects and close.
-     *
+     * <p>
      * Expected situation is nothing gets stuck.
-     *
+     * <p>
      * The test sets SO_LINGER to 0 for outgoing connections to avoid producing
      * many TIME_WAIT sockets, because an available port range can be
      * exhausted.
@@ -316,7 +360,7 @@ public void run() {
      * Verify that we don't exceed a file descriptor limit (and so likely don't
      * leak file descriptors) when trying to connect to an existing node with
      * wrong authentification credentials.
-     *
+     * <p>
      * The test sets SO_LINGER to 0 for outgoing connections to avoid producing
      * many TIME_WAIT sockets, because an available port range can be
      * exhausted.
@@ -354,4 +398,5 @@ public void execute() throws Throwable {
         client.syncOps().ping();
         client.close();
     }
+
 }