Skip to content

Mark a singleton instance as a leader manually #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

Totktonada
Copy link
Member

@Totktonada Totktonada commented Oct 28, 2021

Otherwise 'set' and 'register' tests, which use synchronous spaces, fail
with the 'The synchronous transaction queue doesn't belong to any
instance' error.

Those tests did pass before the change 1 in tarantool, which was made
in the scope of the issue 2. The commit land into release branches as
2.7.2-160-g7310288fa, 2.8.1-168-g806123567, 2.9.0-221-g362e9a668.

Fixes #92


Sorry, I don't know how to run it to test the changes. It is blind
attempt to fix the problem. I would appreciate a help.

Copy link

@sergepetrenko sergepetrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although that's not needed, it's ok to call promote every time an instance starts.
You could only call promote once, during bootstrap. But there's no need to overcomplicate, so LGTM.

@Totktonada
Copy link
Member Author

I didn't know that this information is persisted. It's easy to move it into box.once(), I'll do.

@Totktonada Totktonada force-pushed the Totktonada/gh-92-mark-single-instance-as-leader branch from d915672 to e27335b Compare October 29, 2021 10:51
@Totktonada
Copy link
Member Author

Verified in tarantool/tarantool CI this way:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 8037c30a7a0..0a13c003bbb 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -200,6 +200,7 @@ if (WITH_JEPSEN)
     ExternalProject_Add(
         jepsen-tests
         GIT_REPOSITORY https://github.com/tarantool/jepsen.tarantool
+        GIT_TAG e27335ba54d512dfde7ed33a1182ad5fa48eb93c
         CONFIGURE_COMMAND ""
         BUILD_COMMAND ""
         INSTALL_COMMAND ""

The problem looks fixed.

I found another problem (occurs from time to time, hit me once) with incorrect apt source list:

openstack_compute_instance_v2.instance[0] (remote-exec): E: Type 'to' is not known on line 50 in source list /etc/apt/sources.list
openstack_compute_instance_v2.instance[0] (remote-exec): E: The list of sources could not be read.

I'll try to collect more information about it in background. It is irrelevant here.

Otherwise 'set' and 'register' tests, which use synchronous spaces, fail
with the 'The synchronous transaction queue doesn't belong to any
instance' error.

Those tests did pass before the change [1] in tarantool, which was made
in the scope of the issue [2]. The commit land into release branches as
2.7.2-160-g7310288fa, 2.8.1-168-g806123567, 2.9.0-221-g362e9a668.

[1]: tarantool/tarantool@362e9a6
[2]: tarantool/tarantool#6034

Fixes #92
@Totktonada Totktonada force-pushed the Totktonada/gh-92-mark-single-instance-as-leader branch from e27335b to fde4b54 Compare October 29, 2021 16:23
@Totktonada
Copy link
Member Author

Added information about the change in tarantool, which causes the problem here. Thanks to @sergepetrenko for pointing it out.

@ligurio
Copy link
Member

ligurio commented Nov 1, 2021

Verified in tarantool/tarantool CI this way:

I think it is worth to add a link to successful run - https://github.com/tarantool/tarantool/actions/runs/1403828057

Copy link
Member

@ligurio ligurio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ligurio ligurio merged commit 92eadd7 into master Nov 2, 2021
@ligurio ligurio deleted the Totktonada/gh-92-mark-single-instance-as-leader branch November 2, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single instance testing isn't working
3 participants