-
Notifications
You must be signed in to change notification settings - Fork 0
Mark a singleton instance as a leader manually #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark a singleton instance as a leader manually #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although that's not needed, it's ok to call promote every time an instance starts.
You could only call promote once, during bootstrap. But there's no need to overcomplicate, so LGTM.
I didn't know that this information is persisted. It's easy to move it into |
d915672
to
e27335b
Compare
Verified in tarantool/tarantool CI this way: diff --git a/CMakeLists.txt b/CMakeLists.txt
index 8037c30a7a0..0a13c003bbb 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -200,6 +200,7 @@ if (WITH_JEPSEN)
ExternalProject_Add(
jepsen-tests
GIT_REPOSITORY https://github.com/tarantool/jepsen.tarantool
+ GIT_TAG e27335ba54d512dfde7ed33a1182ad5fa48eb93c
CONFIGURE_COMMAND ""
BUILD_COMMAND ""
INSTALL_COMMAND "" The problem looks fixed. I found another problem (occurs from time to time, hit me once) with incorrect apt source list:
I'll try to collect more information about it in background. It is irrelevant here. |
Otherwise 'set' and 'register' tests, which use synchronous spaces, fail with the 'The synchronous transaction queue doesn't belong to any instance' error. Those tests did pass before the change [1] in tarantool, which was made in the scope of the issue [2]. The commit land into release branches as 2.7.2-160-g7310288fa, 2.8.1-168-g806123567, 2.9.0-221-g362e9a668. [1]: tarantool/tarantool@362e9a6 [2]: tarantool/tarantool#6034 Fixes #92
e27335b
to
fde4b54
Compare
Added information about the change in tarantool, which causes the problem here. Thanks to @sergepetrenko for pointing it out. |
I think it is worth to add a link to successful run - https://github.com/tarantool/tarantool/actions/runs/1403828057 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Otherwise 'set' and 'register' tests, which use synchronous spaces, fail
with the 'The synchronous transaction queue doesn't belong to any
instance' error.
Those tests did pass before the change 1 in tarantool, which was made
in the scope of the issue 2. The commit land into release branches as
2.7.2-160-g7310288fa, 2.8.1-168-g806123567, 2.9.0-221-g362e9a668.
Fixes #92
Sorry, I don't know how to run it to test the changes. It is blind
attempt to fix the problem. I would appreciate a help.