This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Sb/union clean #81
Closed
Sb/union clean #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #44.
Add goods (item) and order_item relation.
This patch is important for graphql query -> avro schema convertor implementation, because both executor and convertor walks over query AST. Part of #7
Extend query object: add `avro_schema` method, which produces Avro schema which can be used to verify or flatten any `query_exequte` result. Closes #7
The changes are debatable, but I'm trying to improve code readability as stated in the comments to [1]. [1]: tarantool/graphql#58
The criteria of correctness is that the following queries should produce
the same results.
```
local gql = ...
local query = [[
query foo_list($offset: foo_offset) {
foo(offset: $offset) {
...
}
}
]]
local variables = {
offset = {
bar = ...,
baz = ...,
}
}
print(yaml.encode(gql:compile(query):execute(variables)))
```
```
local gql = ...
local query = [[
query foo_list($bar: String, $baz: Long) {
foo(offset: {bar: $bar, baz: $baz}) {
...
}
}
]]
local variables = {
bar = ...,
baz = ...,
}
print(yaml.encode(gql:compile(query):execute(variables)))
```
Related to #73.
It is for make the function general and don't have fears of corner
cases. It will loop in case of x = { ofType = x }, but it is anyway
incorrect input.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new type of connections - union connections, as they described in #8. With this connection type it is possible to represent a situation when entities in child table reference different parent tables. For example, let us have child table User and parent tables Basic and Premium. One user in User table may reference to a basic user info in Basic table, while another may reference to a premium info in Premium table. In GraphQL it is represented as Union type like this: