Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Add PCRE matching support for string fields #73

Closed
Totktonada opened this issue Mar 10, 2018 · 4 comments
Closed

Add PCRE matching support for string fields #73

Totktonada opened this issue Mar 10, 2018 · 4 comments
Labels
enhancement New feature or request prio2

Comments

@Totktonada
Copy link
Member

Extracted from #13.

@Totktonada Totktonada added enhancement New feature or request prio1 labels Mar 10, 2018
@Totktonada Totktonada self-assigned this Mar 10, 2018
Totktonada added a commit that referenced this issue Mar 10, 2018
Totktonada added a commit that referenced this issue Mar 12, 2018
Totktonada added a commit that referenced this issue Mar 13, 2018
Totktonada added a commit that referenced this issue Mar 13, 2018
@Totktonada
Copy link
Member Author

Totktonada commented Mar 13, 2018

Plan:

Totktonada added a commit that referenced this issue Mar 13, 2018
Totktonada added a commit that referenced this issue Mar 13, 2018
@Totktonada
Copy link
Member Author

Sink down the issue to prio2 because of the main part of the plan (the first item) is closed.

@Totktonada Totktonada added prio2 and removed prio1 labels Mar 13, 2018
SudoBobo pushed a commit that referenced this issue Mar 14, 2018
@Totktonada Totktonada removed their assignment Mar 27, 2018
Totktonada added a commit that referenced this issue Jun 6, 2018
* Generate object arguments in avro-schema first.
* Generate object arguments for subrecords.
* Better implementation of schema reusage (in convert_schema/types).

TBD: make nested `update` argument fields nullable
TBD: make pcre support subrecords (#73).
TBD: support array, map, union in arguments converting

* Part of #166.
* Fixes #163 (TBD: test).
* Fixes #46 (TBD: test).

Can be followed up with fixing 2nd bullet in #73.
Totktonada added a commit that referenced this issue Jun 13, 2018
* Generate object arguments in avro-schema first.
* Generate object arguments for subrecords.
* Use full path for a GraphQL type name where possible.

* Part of #166.
* Part of #73 (2nd bullet).
* Fixes #163.
* Fixes #46.
@Totktonada
Copy link
Member Author

2nd bullet is done in PR #168.

@Totktonada
Copy link
Member Author

3rd bullet was extracted to the separate issue: #173.

Totktonada added a commit that referenced this issue Jun 13, 2018
* Generate object arguments in avro-schema format first.
* Generate object arguments for subrecords.
* Use full path for a GraphQL type name where possible.

* Part of #166.
* Fixes #73 (2nd bullet).
* Fixes #163.
* Fixes #46.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request prio2
Projects
None yet
Development

No branches or pull requests

1 participant