Fix name clash b/w 1:1 connections and collections #204
Conversation
|
|
||
| local graphql = require('graphql') | ||
|
|
||
| box.cfg{ wal_mode = "none" } |
There was a problem hiding this comment.
I put it because it was in all other /extra tests.
As original author of this tests says, wal_mode = "mode" speed ups tests. But in this test it is useless.
Removed.
There was a problem hiding this comment.
Ouch, I didn’t know that this is common way to write extra tests. So, I vote to get it back for consistency.
graphql/convert_schema/types.lua
Outdated
| @@ -373,7 +373,7 @@ function types.convert(state, avro_schema, opts) | |||
| if context == nil then | |||
| context = { | |||
| field_name = nil, | |||
| path = {}, | |||
| path = {'results'} | |||
There was a problem hiding this comment.
By the way, I prefer to have dangling commas, it makes further diffs easier to read.
There was a problem hiding this comment.
Ok, reasonable, fixed as you say.
| } | ||
| } | ||
|
|
||
| local accessor_1 = graphql.accessor_space.new({ |
There was a problem hiding this comment.
Proposed to move to graphql.new.
| } | ||
| }]]) | ||
|
|
||
| local accessor_2 = graphql.accessor_space.new({ |
There was a problem hiding this comment.
Proposed to move to graphql.new.
|
|
||
| test:isnt(gql_wrapper_2, nil) | ||
|
|
||
| -- Potential lash between second ("hero_meta_collection") and third |
| } | ||
| }]]) | ||
|
|
||
| local accessor_3 = graphql.accessor_space.new({ |
There was a problem hiding this comment.
Proposed to move to graphql.new.
SudoBobo
force-pushed
the
gh-191-name-clash
branch
from
786d90e to
7ad3218
Compare
Before we could not use the same name for collection and 1:1 connection (or collection and 1:1 multi-head connection variant) because this created two different types with same names in GraphQL schema: Object type for collection and InputObject type for connection. Now we can use the same names, since we add 'result_' to the name of GraphQL collection Object type. Close #191, close #104
SudoBobo
force-pushed
the
gh-191-name-clash
branch
from
7ad3218 to
019f2b6
Compare
Before we could not use the same name for collection and 1:1 connection (or collection and 1:1 multi-head connection variant) because this created two different types with same names in GraphQL schema: Object type for collection and InputObject type for connection. Now we can use the same names, since we add 'result_' to the name of GraphQL collection Object type.
Close #191, close #104