Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Name clash when 1:1 connection and multi-head 1:1 connection variant have the same name #191

Closed
Totktonada opened this issue Jul 3, 2018 · 1 comment · Fixed by #204
Closed

Name clash when 1:1 connection and multi-head 1:1 connection variant have the same name #191

Totktonada opened this issue Jul 3, 2018 · 1 comment · Fixed by #204
Assignees
@SudoBobo
Labels
bug Something isn't working customer prio3

Comments

@Totktonada
Copy link
Member

Object (I guess for the variant) and InputObject for filtering by a connection have the same names.

  1. We can use bare names only for box objects, but not for the variant type itself, I think (including muti-head connection).
  2. We should not use a bare name for an InputObject for filtering by a connection.
@Totktonada Totktonada added bug Something isn't working customer labels Jul 3, 2018
@SudoBobo SudoBobo self-assigned this Aug 2, 2018
@SudoBobo
Copy link
Contributor

SudoBobo commented Aug 2, 2018

I guess we may face the same issue in case of 1:N multihead connections.

SudoBobo added a commit that referenced this issue Aug 9, 2018
@SudoBobo
Fix name clash b/w 1:1 connections and collections
786d90e 
Before we could not use the same name for collection and
1:1 connection (or collection and 1:1 multi-head connection
variant) because this created two different types with same
names in GraphQL schema: Object type for collection and
InputObject type for connection. Now we can use the same names,
since we add 'result_' to the name of GraphQL collection
Object type.

Close #191, close #104
@SudoBobo SudoBobo mentioned this issue Aug 9, 2018
Merged
SudoBobo added a commit that referenced this issue Aug 10, 2018
@SudoBobo
Fix name clash b/w 1:1 connections and collections
7ad3218 
Before we could not use the same name for collection and
1:1 connection (or collection and 1:1 multi-head connection
variant) because this created two different types with same
names in GraphQL schema: Object type for collection and
InputObject type for connection. Now we can use the same names,
since we add 'result_' to the name of GraphQL collection
Object type.

Close #191, close #104
SudoBobo added a commit that referenced this issue Aug 10, 2018
@SudoBobo
Fix name clash b/w 1:1 connections and collections
019f2b6 
Before we could not use the same name for collection and
1:1 connection (or collection and 1:1 multi-head connection
variant) because this created two different types with same
names in GraphQL schema: Object type for collection and
InputObject type for connection. Now we can use the same names,
since we add 'result_' to the name of GraphQL collection
Object type.

Close #191, close #104
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SudoBobo SudoBobo

Labels
bug Something isn't working customer prio3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix name clash b/w 1:1 connections and collections tarantool/graphql.0
3 participants
@Totktonada @opomuc @SudoBobo