Skip to content

api: add helper Dialer implementations #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2024
Merged

api: add helper Dialer implementations #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ Versioning](http://semver.org/spec/v2.0.0.html) except to the first release.
the response (#237)
- Ability to mock connections for tests (#237). Added new types `MockDoer`,
`MockRequest` to `test_helpers`.
- `AuthDialer` type for creating a dialer with authentication (#301)
- `ProtocolDialer` type for creating a dialer with `ProtocolInfo` receiving and
check (#301)
- `GreetingDialer` type for creating a dialer, that fills `Greeting` of a
connection (#301)

### Changed

Expand Down
4 changes: 3 additions & 1 deletion connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,9 @@ func (conn *Connection) dial(ctx context.Context) error {
}

conn.addr = c.Addr()
conn.Greeting.Version = c.Greeting().Version
connGreeting := c.Greeting()
conn.Greeting.Version = connGreeting.Version
conn.Greeting.Salt = connGreeting.Salt
conn.serverProtocolInfo = c.ProtocolInfo()

spaceAndIndexNamesSupported :=
Expand Down
Loading