-
Notifications
You must be signed in to change notification settings - Fork 60
api: add helper Dialer implementations #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8ce3479
to
582353f
Compare
AuthDialer
and ProtocolDialer
582353f
to
9292448
Compare
0f7d508
to
7038359
Compare
1a49b28
to
963c147
Compare
963c147
to
38edd2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch!
Please, update the commit message: add GreetingDialer too. |
38edd2a
to
023817d
Compare
It is in the commit message:
|
But the title is confusing. It could be something like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch! lgtm
AuthDialer
and ProtocolDialer
To disable SSL by default we want to transfer `OpenSslDialer` to the go-openssl repository. In order to do so, we need to minimize the amount of copy-paste of the private functions. `AuthDialer` is created as a dialer-wrapper, that calls authentication methods. `ProtoDialer` is created to receive and check the `ProtocolInfo` in the created connection. `GreetingDialer` is created to fill the `Greeting` in the created connection. Part of #301
023817d
to
c56f978
Compare
Oh, I thought you were talking about commit body, not header. Updated commit header and PR header too. |
To disable SSL by default we want to transfer
OpenSslDialer
to the go-openssl repository. In order to do so, we need to minimize the amount of copy-paste of the private functions.AuthDialer
is created as a dialer-wrapper, that calls authentication methods.ProtoDialer
is created to check theProtocolInfo
in the created connection.GreetingDialer
is created to fill theGreeting
in the created connection.I didn't forget about (remove if it is not applicable):
Related issues:
Part of #301