Skip to content

Follow-ups for CRUD API #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AnaNek opened this issue Mar 7, 2023 · 0 comments · Fixed by #273
Closed

Follow-ups for CRUD API #271

AnaNek opened this issue Mar 7, 2023 · 0 comments · Fixed by #273
Assignees
@oleg-jukovec

Comments

@AnaNek
Copy link

AnaNek commented Mar 7, 2023 •
edited by oleg-jukovec
Loading

  1. Implement an ability to decode custom types via Result/ResultMany.
  2. Add examples.
  3. Add some benchmarks/make request types immutable.

CRUD API has been provided by PR #263.
@oleg-jukovec oleg-jukovec self-assigned this Mar 7, 2023
@oleg-jukovec oleg-jukovec added 2sp and removed 2sp labels Mar 7, 2023
oleg-jukovec added a commit that referenced this issue Mar 13, 2023
@oleg-jukovec
crud: remove NewEncoder/NewDecoder from the API
d956e29 
This is only needed for tests. Let it be private API.

Part of #271
oleg-jukovec added a commit that referenced this issue Mar 13, 2023
@oleg-jukovec
crud: improve Result* types
9cc0dde 
Now a user can specify his custom type as a type for rows. The patch
also removes unnecessary types to make it easier for a user to work
with the API.

Part of #271
oleg-jukovec added a commit that referenced this issue Mar 13, 2023
@oleg-jukovec
crud: improve Result* types
f543da2 
Now a user can specify his custom type as a type for rows. The patch
also removes unnecessary types to make it easier for a user to work
with the API.

Part of #271
oleg-jukovec added a commit that referenced this issue Mar 13, 2023
@oleg-jukovec
crud: remove NewEncoder/NewDecoder from the API
79f22ea 
This is only needed for tests. Let it be private API.

Part of #271
oleg-jukovec added a commit that referenced this issue Mar 13, 2023
@oleg-jukovec
crud: improve Result* types
845ef06 
Now a user can specify his custom type as a type for rows. The patch
also removes unnecessary types to make it easier for a user to work
with the API.

Part of #271
oleg-jukovec added a commit that referenced this issue Mar 13, 2023
@oleg-jukovec
crud: remove NewEncoder/NewDecoder from the API
306ef71 
This is only needed for tests. Let it be private API.

Part of #271
oleg-jukovec added a commit that referenced this issue Mar 13, 2023
@oleg-jukovec
crud: improve Result* types
48337a4 
Now a user can specify his custom type as a type for rows. The patch
also removes unnecessary types to make it easier for a user to work
with the API.

Part of #271
oleg-jukovec added a commit that referenced this issue Mar 15, 2023
@oleg-jukovec
crud: allow any type as Tuple
0c7a12c 
This is necessary to use a custom types with custom encoders as tuples.

Part of #271
oleg-jukovec added a commit that referenced this issue Mar 15, 2023
@oleg-jukovec
crud: make less allocations
117f72f 
In this patch, we try to make less allocations per a request.

Part of #271
oleg-jukovec added a commit that referenced this issue Mar 15, 2023
@oleg-jukovec
crud: make requests immutable
e0136a3 
Closes #271
oleg-jukovec added a commit that referenced this issue Mar 15, 2023
@oleg-jukovec
crud: allow any type as Tuple
6d684ab 
This is necessary to use a custom types with custom encoders as tuples.

Part of #271
oleg-jukovec added a commit that referenced this issue Mar 15, 2023
@oleg-jukovec
crud: make less allocations
3a98b2c 
In this patch, we try to make less allocations per a request.

Part of #271
oleg-jukovec added a commit that referenced this issue Mar 15, 2023
@oleg-jukovec
crud: make requests immutable
48f383a 
Closes #271
@oleg-jukovec oleg-jukovec mentioned this issue Mar 15, 2023
Merged
3 tasks
oleg-jukovec added a commit that referenced this issue Mar 20, 2023
@oleg-jukovec
crud: remove NewEncoder/NewDecoder from the API
686d006 
This is only needed for tests. Let it be private API.

Part of #271
oleg-jukovec added a commit that referenced this issue Mar 20, 2023
@oleg-jukovec
crud: improve Result* types
d9a6049 
Now a user can specify his custom type as a type for rows. The patch
also removes unnecessary types to make it easier for a user to work
with the API.

Part of #271
oleg-jukovec added a commit that referenced this issue Mar 20, 2023
@oleg-jukovec
crud: allow any type as Tuple
7c99521 
This is necessary to use a custom types with custom encoders as tuples.

Part of #271
oleg-jukovec added a commit that referenced this issue Mar 20, 2023
@oleg-jukovec
crud: make less allocations
009084f 
In this patch, we try to make less allocations per a request.

Part of #271
oleg-jukovec added a commit that referenced this issue Mar 20, 2023
@oleg-jukovec
crud: make requests immutable
d7a422b 
Closes #271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleg-jukovec oleg-jukovec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

crud: improvments tarantool/go-tarantool
2 participants
@oleg-jukovec @AnaNek