crud: make less allocations

In this patch, we try to make less allocations per a request.

Part of #271

Author: oleg-jukovec

crud/common.go

@@ -63,30 +63,26 @@ type baseRequest struct {
 	impl *tarantool.CallRequest
 }
 
-func (req *baseRequest) initImpl(methodName string) {
-	req.impl = tarantool.NewCall17Request(methodName)
+func newCall(method string) *tarantool.CallRequest {
+	return tarantool.NewCall17Request(method)
 }
 
 // Code returns IPROTO code for CRUD request.
-func (req *baseRequest) Code() int32 {
+func (req baseRequest) Code() int32 {
 	return req.impl.Code()
 }
 
 // Ctx returns a context of CRUD request.
-func (req *baseRequest) Ctx() context.Context {
+func (req baseRequest) Ctx() context.Context {
 	return req.impl.Ctx()
 }
 
 // Async returns is CRUD request expects a response.
-func (req *baseRequest) Async() bool {
+func (req baseRequest) Async() bool {
 	return req.impl.Async()
 }
 
 type spaceRequest struct {
 	baseRequest
 	space string
 }
-
-func (req *spaceRequest) setSpace(space string) {
-	req.space = space
-}

crud/count.go

@@ -42,17 +42,23 @@ type CountOpts struct {
 func (opts CountOpts) EncodeMsgpack(enc *encoder) error {
 	const optsCnt = 9
 
-	options := [optsCnt]option{opts.Timeout, opts.VshardRouter,
-		opts.Mode, opts.PreferReplica, opts.Balance,
-		opts.YieldEvery, opts.BucketId, opts.ForceMapCall,
-		opts.Fullscan}
 	names := [optsCnt]string{timeoutOptName, vshardRouterOptName,
 		modeOptName, preferReplicaOptName, balanceOptName,
 		yieldEveryOptName, bucketIdOptName, forceMapCallOptName,
 		fullscanOptName}
 	values := [optsCnt]interface{}{}
+	exists := [optsCnt]bool{}
+	values[0], exists[0] = opts.Timeout.Get()
+	values[1], exists[1] = opts.VshardRouter.Get()
+	values[2], exists[2] = opts.Mode.Get()
+	values[3], exists[3] = opts.PreferReplica.Get()
+	values[4], exists[4] = opts.Balance.Get()
+	values[5], exists[5] = opts.YieldEvery.Get()
+	values[6], exists[6] = opts.BucketId.Get()
+	values[7], exists[7] = opts.ForceMapCall.Get()
+	values[8], exists[8] = opts.Fullscan.Get()
 
-	return encodeOptions(enc, options[:], names[:], values[:])
+	return encodeOptions(enc, names[:], values[:], exists[:])
 }
 
 // CountRequest helps you to create request object to call `crud.count`
@@ -73,8 +79,8 @@ type countArgs struct {
 // NewCountRequest returns a new empty CountRequest.
 func NewCountRequest(space string) *CountRequest {
 	req := new(CountRequest)
-	req.initImpl("crud.count")
-	req.setSpace(space)
+	req.impl = newCall("crud.count")
+	req.space = space
 	req.conditions = nil
 	req.opts = CountOpts{}
 	return req

crud/delete.go

@@ -27,8 +27,8 @@ type deleteArgs struct {
 // NewDeleteRequest returns a new empty DeleteRequest.
 func NewDeleteRequest(space string) *DeleteRequest {
 	req := new(DeleteRequest)
-	req.initImpl("crud.delete")
-	req.setSpace(space)
+	req.impl = newCall("crud.delete")
+	req.space = space
 	req.key = []interface{}{}
 	req.opts = DeleteOpts{}
 	return req

crud/get.go

@@ -33,15 +33,19 @@ type GetOpts struct {
 func (opts GetOpts) EncodeMsgpack(enc *encoder) error {
 	const optsCnt = 7
 
-	options := [optsCnt]option{opts.Timeout, opts.VshardRouter,
-		opts.Fields, opts.BucketId, opts.Mode,
-		opts.PreferReplica, opts.Balance}
 	names := [optsCnt]string{timeoutOptName, vshardRouterOptName,
 		fieldsOptName, bucketIdOptName, modeOptName,
 		preferReplicaOptName, balanceOptName}
 	values := [optsCnt]interface{}{}
+	exists := [optsCnt]bool{}
+	values[0], exists[0] = opts.Timeout.Get()
+	values[1], exists[1] = opts.VshardRouter.Get()
+	values[1], exists[1] = opts.BucketId.Get()
+	values[2], exists[2] = opts.Mode.Get()
+	values[3], exists[3] = opts.PreferReplica.Get()
+	values[4], exists[4] = opts.Balance.Get()
 
-	return encodeOptions(enc, options[:], names[:], values[:])
+	return encodeOptions(enc, names[:], values[:], exists[:])
 }
 
 // GetRequest helps you to create request object to call `crud.get`
@@ -62,8 +66,8 @@ type getArgs struct {
 // NewGetRequest returns a new empty GetRequest.
 func NewGetRequest(space string) *GetRequest {
 	req := new(GetRequest)
-	req.initImpl("crud.get")
-	req.setSpace(space)
+	req.impl = newCall("crud.get")
+	req.space = space
 	req.key = []interface{}{}
 	req.opts = GetOpts{}
 	return req

crud/insert.go

@@ -27,8 +27,8 @@ type insertArgs struct {
 // NewInsertRequest returns a new empty InsertRequest.
 func NewInsertRequest(space string) *InsertRequest {
 	req := new(InsertRequest)
-	req.initImpl("crud.insert")
-	req.setSpace(space)
+	req.impl = newCall("crud.insert")
+	req.space = space
 	req.tuple = []interface{}{}
 	req.opts = InsertOpts{}
 	return req
@@ -83,8 +83,8 @@ type insertObjectArgs struct {
 // NewInsertObjectRequest returns a new empty InsertObjectRequest.
 func NewInsertObjectRequest(space string) *InsertObjectRequest {
 	req := new(InsertObjectRequest)
-	req.initImpl("crud.insert_object")
-	req.setSpace(space)
+	req.impl = newCall("crud.insert_object")
+	req.space = space
 	req.object = MapObject{}
 	req.opts = InsertObjectOpts{}
 	return req

crud/insert_many.go

@@ -27,8 +27,8 @@ type insertManyArgs struct {
 // NewInsertManyRequest returns a new empty InsertManyRequest.
 func NewInsertManyRequest(space string) *InsertManyRequest {
 	req := new(InsertManyRequest)
-	req.initImpl("crud.insert_many")
-	req.setSpace(space)
+	req.impl = newCall("crud.insert_many")
+	req.space = space
 	req.tuples = []Tuple{}
 	req.opts = InsertManyOpts{}
 	return req
@@ -83,8 +83,8 @@ type insertObjectManyArgs struct {
 // NewInsertObjectManyRequest returns a new empty InsertObjectManyRequest.
 func NewInsertObjectManyRequest(space string) *InsertObjectManyRequest {
 	req := new(InsertObjectManyRequest)
-	req.initImpl("crud.insert_object_many")
-	req.setSpace(space)
+	req.impl = newCall("crud.insert_object_many")
+	req.space = space
 	req.objects = []Object{}
 	req.opts = InsertObjectManyOpts{}
 	return req

crud/len.go

@@ -28,8 +28,8 @@ type lenArgs struct {
 // NewLenRequest returns a new empty LenRequest.
 func NewLenRequest(space string) *LenRequest {
 	req := new(LenRequest)
-	req.initImpl("crud.len")
-	req.setSpace(space)
+	req.impl = newCall("crud.len")
+	req.space = space
 	req.opts = LenOpts{}
 	return req
 }

crud/max.go

@@ -27,8 +27,8 @@ type maxArgs struct {
 // NewMaxRequest returns a new empty MaxRequest.
 func NewMaxRequest(space string) *MaxRequest {
 	req := new(MaxRequest)
-	req.initImpl("crud.max")
-	req.setSpace(space)
+	req.impl = newCall("crud.max")
+	req.space = space
 	req.index = []interface{}{}
 	req.opts = MaxOpts{}
 	return req

crud/min.go

@@ -27,8 +27,8 @@ type minArgs struct {
 // NewMinRequest returns a new empty MinRequest.
 func NewMinRequest(space string) *MinRequest {
 	req := new(MinRequest)
-	req.initImpl("crud.min")
-	req.setSpace(space)
+	req.impl = newCall("crud.min")
+	req.space = space
 	req.index = []interface{}{}
 	req.opts = MinOpts{}
 	return req