Ensure last chunk of XML data is parsed #547
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes case where last chunk was skipped during parse
|
Thanks! Could you add the test case here? https://github.com/swiftwasm/integration-tests |
I'm running in to a few issues setting up integration tests in that repo. Should I open an issue over there to troubleshoot or what is the preferred course of action? It doesn't look like any existing tests there use libxml2 and I'm not sure of the preferred way to set that up |
|
BTW, it looks the lines are already upstreamed by swiftlang#3051 |
|
I opened a PR upstream here: swiftlang#4683 |
|
Closing as that change was upstreamed and merged here: #571 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes case where last chunk was skipped during parse
Appears some refactoring in this PR may have introduced this behavior.
I was unable to get the test suites running locally after following the "Getting Started" guide- Are there test cases that I can add somewhere to cover this? The bug is exhibited when parsing any XML document. I noticed this when parsing a document smaller than
_chunkSize