Fix XML parsing in WASI environment #4683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Final chunk of XML document was being skipped when parsing when in a WASI environment
|
@swift-ci please test |
|
CC: @MaxDesiatov |
|
@swift-ci please test |
MaxDesiatov
approved these changes
Jan 7, 2023
|
@swift-ci test macOS |
|
I can't quite tell from the output of the macOS action- Are there legitimate test failures I need to address? |
|
The test failure seems unrelated to me, but I requested at least one more review just in case. |
|
@swift-ci please test macOS platform |
1 similar comment
|
@swift-ci please test macOS platform |
parkera
reviewed
Feb 2, 2023
| if chunkStart >= data.count || chunkEnd >= data.count { | ||
| break | ||
| } | ||
| while result && chunkStart != chunkEnd { |
There was a problem hiding this comment.
This looks safe based on reading the code below. One reason why I personally stick with < checks in places like this instead of != is that if a later change or some missed path advances beyond the end, we fail safely instead of entering an infinite loop.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final chunk of XML document was being skipped when parsing when in a WASI environment