Skip to content

[6.0][SourceLocationConverter] Performance improvement #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 24, 2024
Merged

[6.0][SourceLocationConverter] Performance improvement #2664

merged 4 commits into from
May 24, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented May 23, 2024 •
edited
Loading

Cherry-pick #2663 into release/6.0

  • Explanation: Improve the performance of SourceLocationConverter initialization, at the cost of a bit readability.
  • Scope: Source location calculation
  • Risk: Low. No API changes, no use of risky experimental features.
  • Testing: Passes current test suite, also added a few test cases to verify
  • Issues: rdar://128618516
  • Reviewer: Hamish Knight (@hamishknight) Alex Hoppen (@ahoppen)

@rintaro rintaro requested review from ahoppen and bnbarham as code owners May 23, 2024 16:34
@rintaro
Copy link
Member Author

rintaro commented May 23, 2024

@swift-ci Please test

@rintaro rintaro merged commit d9c1feb into swiftlang:release/6.0 May 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @bnbarham