[SourceLocationConverter] Performance improvement #2663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
hamishknight
approved these changes
May 22, 2024
ahoppen
approved these changes
May 22, 2024
| var position: AbsolutePosition = .startOfFile | ||
| let addLine = { (lineLength: SourceLength) in | ||
| var sourceLocationDirectives: [(sourceLine: Int, arguments: SourceLocationDirectiveArguments?)] = [] | ||
| let prefix = tree.raw.forEachLineLength { lineLength in |
There was a problem hiding this comment.
prefix doesn’t really make sense as a variable name here, right? Shouldn’t it be sourceFileLength or something? Also, the usage of prefix in RawSyntax.forEachLineLength + the comment on it seem pretty confusing to me. Not your doing but might be worth to clean that up along the way.
There was a problem hiding this comment.
This prefix is more like lastLineLength. I changed the naming so.
I didn't changed the naming in forEachLineLength functions, because I wasn't able to come up with better naming. It's like "the length of the current line so far"
rintaro
force-pushed
the
perf-computelines
branch
from
e54f8d1 to
6a81e49
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TokenSequence. Instead, visitRawSyntaxtree manuallyArrayofRawTriviaPiece. Instead, scan the whole token text directly if available#sourceLocation()directives in one-pass