suggestedFilename always returns a valid filename #5019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@jrflat to review |
jrflat
reviewed
Jul 20, 2024
jrflat
approved these changes
Sep 4, 2024
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property
suggestedFilenameis documented with:The default initializer
init(url:mimeType:expectedContentLength:textEncodingName:)had a correct implementation, but the requiredinit?(coder:)was unsafe.This is the same PR as #2643 created in February 2020, but for the main branch.
This is the same PR as #2897 created in October 2020, but it was closed for being unreviewed for too long.