suggestedFilename always returns a valid filename

[Coeur]

The property suggestedFilename is documented with:

This method always returns a valid filename.

The default initializer init(url:mimeType:expectedContentLength:textEncodingName:) had a correct implementation, but the required init?(coder:) was unsafe.

[compnerd]

Could you please add a test case for this?

[Coeur]

I'll need some time to see how test cases are done.

[compnerd]

They are just XCTest based tests in Tests/

[spevans]

TestFoundation not Tests :)

[compnerd]

@Coeur I would recommend building on Windows or Linux. I suspect that you will need to adjust the Xcode build some since I imagine that the tests haven't been built with that for a while (normally the compatibility test suite is run on macOS).

[spevans]

It should build fine on macOS in Xcode as that is how I develop on it. Use the default Xcode 11.3.1 toolchain and delete DerivedData.

Ensure swift-corelibs-xctest is checked out and open the Foundation.xcworkspace not Foundation.xcodeproj. Lastly just run the TestFoundation target, that should build everything correctly.

Ive just double-checked master builds and runs ok and I dont see any issues.

[Coeur]

Oh, thank you @spevans, I forgot swift-corelibs-xctest. It was documented in Docs/GettingStarted.md and Docs/Testing.md. I missed this folder somehow.

[Coeur]

@compnerd @spevans test added.

[spevans]

@swift-ci test

[spevans]

Sometimes the messages between github and swift-ci get lost, i'll start another test

[spevans]

@swift-ci test

[Coeur]

@spevans @millenomi can we get it merged? Thank you.

[shahmishal]

The Swift project moved the default branch to main and deleted master branch, so GitHub automatically closed the PR. Please re-create pull request with main branch.

More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412